COFF: Give manifest resource file a name.

[pcc]

Summary

Without this, /linkrepro would create an invalid tar file.

No tests because this requires Windows and the linkrepro tests
require not-Windows.

[ruiu]

LGTM

[thakis]

because this requires Windows an

Why does this require Windows? lld does manifest stuff natively nowadays, so this should be testable on non-Windows I think.

[pcc]

In D38973#902376, @thakis wrote:

because this requires Windows an

Why does this require Windows? lld does manifest stuff natively nowadays, so this should be testable on non-Windows I think.

That's true. Our implementation of the Windows maniifest tool appears to require libxml, so I suppose we could gate the test on the libxml2 feature. We might also want to do something like D38977 to test this on Windows as well.

[pcc]

In D38973#902432, @pcc wrote:

In D38973#902376, @thakis wrote:

because this requires Windows an

Why does this require Windows? lld does manifest stuff natively nowadays, so this should be testable on non-Windows I think.

That's true. Our implementation of the Windows maniifest tool appears to require libxml, so I suppose we could gate the test on the libxml2 feature. We might also want to do something like D38977 to test this on Windows as well.

I ended up adding a test for this commit in rL316547.

lld/trunk/COFF/DriverUtils.cpp

 
 static std::unique_ptr<MemoryBuffer>
 createMemoryBufferForManifestRes(size_t ManifestSize) {
   size_t ResSize = alignTo(
       object::WIN_RES_MAGIC_SIZE + object::WIN_RES_NULL_ENTRY_SIZE +
           sizeof(object::WinResHeaderPrefix) + sizeof(object::WinResIDs) +
           sizeof(object::WinResHeaderSuffix) + ManifestSize,
       object::WIN_RES_DATA_ALIGNMENT);
-  return MemoryBuffer::getNewMemBuffer(ResSize);
+  return MemoryBuffer::getNewMemBuffer(ResSize,
+                                       Config->OutputFile + ".manifest.res");
 }
 
 static void writeResFileHeader(char *&Buf) {
   memcpy(Buf, COFF::WinResMagic, sizeof(COFF::WinResMagic));
   Buf += sizeof(COFF::WinResMagic);
   memset(Buf, 0, object::WIN_RES_NULL_ENTRY_SIZE);
   Buf += object::WIN_RES_NULL_ENTRY_SIZE;
 }