This is an archive of the discontinued LLVM Phabricator instance.

[xray] Fix CMake for X-RAY tests
ClosedPublic

Authored by george.karpenkov on Oct 13 2017, 6:15 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

dberris requested changes to this revision.Oct 14 2017, 2:13 AM

It looks like you don't have llvm-commits in the subscribers.

This revision now requires changes to proceed.Oct 14 2017, 2:13 AM

Adding LLVM commits as requested.
@dberris better now?

Sent email manually, as the email does no get sent if the CC list is updated =(

dberris accepted this revision.Oct 14 2017, 2:26 PM

Thanks -- I'm not entirely sure how this changes things, but if it works then I'm happy. :)

This revision is now accepted and ready to land.Oct 14 2017, 2:26 PM

@dberris to be frank neither do I.
There seems to be a separate llvm-xray target, which is not invoked when you depend on xray.
As for target properties, somehow unit tests does not get picked up without it.
(yet somehow tsan's ones happily run without).

This revision was automatically updated to reflect the committed changes.