[ExecutionEngine] Correct the size of a write in a COFF i386 relocation

[xiaobai]

Summary

We want to be writing a 32bit value, so we should be writing 4 bytes
instead of 2.

[smeenai]

Looks like a pretty simple and obvious fix.

[xiaobai]

Thanks for the review @smeenai! I don't have commit access, would you mind committing this for me?

[smeenai]

I can commit it for you, but I remembered that this should probably include a test case, assuming that there are tests set up for this functionality (and I hope there are).

[xiaobai]

Updated the test to ensure that this functionality is tested.

[xiaobai]

Replacing uses of space with tab where appropriate.

[xiaobai]

Thanks to @compnerd for the help with the test case. :)

lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldCOFFI386.h

case COFF::IMAGE_REL_I386_SECREL:
       // 32-bit offset of the target from the beginning of its section.
       assert(static_cast<int32_t>(RE.Addend) <= INT32_MAX &&
              "relocation overflow");
       assert(static_cast<int32_t>(RE.Addend) >= INT32_MIN &&
              "relocation underflow");
       DEBUG(dbgs() << "\t\tOffset: " << RE.Offset
                    << " RelType: IMAGE_REL_I386_SECREL Value: " << RE.Addend
                    << '\n');
-      writeBytesUnaligned(RE.Addend, Target, 2);
+      writeBytesUnaligned(RE.Addend, Target, 4);
       break;
     default:
       llvm_unreachable("unsupported relocation type");
     }
   }
 
   void registerEHFrames() override {}
 };
 
 }
 
 #endif