This is an archive of the discontinued LLVM Phabricator instance.

Differential D38828

lld: Reorder dependent libraries alphabetically
ClosedPublic

Authored by chapuni on Oct 11 2017, 4:08 PM.

Details

Reviewers
ruiu
Commits
rGd791eaa55940: lld: Reorder libdeps.
rLLD315529: lld: Reorder libdeps.
rL315529: lld: Reorder libdeps.
Summary

Although it is trivial change, I am afraid if it would be intentional, like performance improvements. May I commit it?

Diff Detail

Repository
rL LLVM

Event Timeline

chapuni created this revision.Oct 11 2017, 4:08 PM
Herald added subscribers: mgorny, emaste. · View Herald TranscriptOct 11 2017, 4:08 PM
ruiu accepted this revision.Oct 11 2017, 4:15 PM

LGTM

This revision is now accepted and ready to land.Oct 11 2017, 4:15 PM
Closed by commit rL315529: lld: Reorder libdeps. (authored by chapuni). · Explain WhyOct 11 2017, 4:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
COFF/
6 lines
ELF/
2 lines
MinGW/
2 lines
lib/
Driver/
2 lines
ReaderWriter/
MachO/
2 lines
tools/
lld/
2 lines

Diff 118720

lld/trunk/COFF/CMakeLists.txt

Show All 25 Linesadd_lld_library(lldCOFF
LINK_COMPONENTS LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD} ${LLVM_TARGETS_TO_BUILD}
BinaryFormat BinaryFormat
BitReader BitReader
Core Core
DebugInfoCodeView DebugInfoCodeView
DebugInfoMSF DebugInfoMSF
DebugInfoPDB DebugInfoPDB
LTO
LibDriver LibDriver
Object LTO
MC MC
MCDisassembler MCDisassembler
Target Object
Option Option
Support Support
Target
WindowsManifest WindowsManifest
LINK_LIBS LINK_LIBS
lldCommon lldCommon
lldCore lldCore
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
DEPENDS DEPENDS
COFFOptionsTableGen COFFOptionsTableGen
${tablegen_deps} ${tablegen_deps}
) )

lld/trunk/ELF/CMakeLists.txt

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Linesadd_lld_library(lldELF
BitWriter BitWriter
Codegen Codegen
Core Core
DebugInfoDWARF DebugInfoDWARF
Demangle Demangle
IPO IPO
Linker Linker
LTO LTO
MC
Object Object
Option Option
Passes Passes
MC
Support Support
Target Target
TransformUtils TransformUtils
LINK_LIBS LINK_LIBS
lldCommon lldCommon
lldCore lldCore
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
DEPENDS DEPENDS
ELFOptionsTableGen ELFOptionsTableGen
${tablegen_deps} ${tablegen_deps}
) )

lld/trunk/MinGW/CMakeLists.txt

set(LLVM_TARGET_DEFINITIONS Options.td) set(LLVM_TARGET_DEFINITIONS Options.td)
tablegen(LLVM Options.inc -gen-opt-parser-defs) tablegen(LLVM Options.inc -gen-opt-parser-defs)
add_public_tablegen_target(MinGWOptionsTableGen) add_public_tablegen_target(MinGWOptionsTableGen)
if(NOT LLD_BUILT_STANDALONE) if(NOT LLD_BUILT_STANDALONE)
set(tablegen_deps intrinsics_gen) set(tablegen_deps intrinsics_gen)
endif() endif()
add_lld_library(lldMinGW add_lld_library(lldMinGW
Driver.cpp Driver.cpp
LINK_COMPONENTS LINK_COMPONENTS
Support
Option Option
Support
LINK_LIBS LINK_LIBS
lldCOFF lldCOFF
DEPENDS DEPENDS
MinGWOptionsTableGen MinGWOptionsTableGen
${tablegen_deps} ${tablegen_deps}
) )

lld/trunk/lib/Driver/CMakeLists.txt

set(LLVM_TARGET_DEFINITIONS DarwinLdOptions.td) set(LLVM_TARGET_DEFINITIONS DarwinLdOptions.td)
tablegen(LLVM DarwinLdOptions.inc -gen-opt-parser-defs) tablegen(LLVM DarwinLdOptions.inc -gen-opt-parser-defs)
add_public_tablegen_target(DriverOptionsTableGen) add_public_tablegen_target(DriverOptionsTableGen)
add_lld_library(lldDriver add_lld_library(lldDriver
DarwinLdDriver.cpp DarwinLdDriver.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${LLD_INCLUDE_DIR}/lld/Driver ${LLD_INCLUDE_DIR}/lld/Driver
LINK_COMPONENTS LINK_COMPONENTS
Object Object
Option Option
Support Support
LINK_LIBS LINK_LIBS
lldMachO
lldCore lldCore
lldMachO
lldReaderWriter lldReaderWriter
lldYAML lldYAML
) )
add_dependencies(lldDriver DriverOptionsTableGen) add_dependencies(lldDriver DriverOptionsTableGen)

lld/trunk/lib/ReaderWriter/MachO/CMakeLists.txt

Show All 15 Linesadd_lld_library(lldMachO
ObjCPass.cpp ObjCPass.cpp
ShimPass.cpp ShimPass.cpp
StubsPass.cpp StubsPass.cpp
TLVPass.cpp TLVPass.cpp
WriterMachO.cpp WriterMachO.cpp
LINK_COMPONENTS LINK_COMPONENTS
DebugInfoDWARF DebugInfoDWARF
Demangle
Object Object
Support Support
Demangle
LINK_LIBS LINK_LIBS
lldCore lldCore
lldYAML lldYAML
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
) )
include_directories(.) include_directories(.)

lld/trunk/tools/lld/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_lld_tool(lld add_lld_tool(lld
lld.cpp lld.cpp
) )
target_link_libraries(lld target_link_libraries(lld
lldDriver
lldCOFF lldCOFF
lldDriver
lldELF lldELF
lldMinGW lldMinGW
) )
install(TARGETS lld install(TARGETS lld
RUNTIME DESTINATION bin) RUNTIME DESTINATION bin)
if(NOT LLD_SYMLINKS_TO_CREATE) if(NOT LLD_SYMLINKS_TO_CREATE)
set(LLD_SYMLINKS_TO_CREATE lld-link ld.lld) set(LLD_SYMLINKS_TO_CREATE lld-link ld.lld)
endif() endif()
foreach(link ${LLD_SYMLINKS_TO_CREATE}) foreach(link ${LLD_SYMLINKS_TO_CREATE})
add_lld_symlink(${link} lld) add_lld_symlink(${link} lld)
endforeach() endforeach()