This is an archive of the discontinued LLVM Phabricator instance.

[X86] test/testn intrinsics lowering to IR. clang side
ClosedPublic

Authored by uriel.k on Oct 10 2017, 8:11 AM.

Details

Summary

Changed Header files of the intrinsics fro lowering test and testn intrinsics to IR code.
Removed test and testn builtins from clang

this is the clang side, the llvm side revision is D38736.

Diff Detail

Event Timeline

uriel.k created this revision.Oct 10 2017, 8:11 AM
craig.topper added inline comments.Oct 16 2017, 4:29 PM
lib/Headers/avx512bwintrin.h
2109

Can you align this with the opening paren on the line above? Same with all the other functions below.

uriel.k updated this revision to Diff 121699.Nov 6 2017, 1:52 AM
uriel.k marked an inline comment as done.
uriel.k updated this revision to Diff 121716.Nov 6 2017, 3:56 AM
craig.topper added inline comments.Nov 6 2017, 10:52 AM
lib/Headers/avx512vlbwintrin.h
2801

Sorry I didn't catch this before, but can you use _MM_CMPINT_NE and _MM_CMPINT_EQ instead of '4' and '0' in all of these? Then no one has to guess what 4 and 0 means.

craig.topper added inline comments.Nov 6 2017, 10:59 AM
lib/Headers/avx512vlbwintrin.h
2801

Better yet, use _mm512_cmpneq_epi32_mask, __mm512_cmpeq_epi32_mask and friends

uriel.k updated this revision to Diff 122082.Nov 8 2017, 6:24 AM
uriel.k marked 2 inline comments as done.
uriel.k added inline comments.Nov 8 2017, 6:29 AM
lib/Headers/avx512vlbwintrin.h
2801

For strange reason this line moved and is not aligned with the open paren above it. If there are no other corrections I'll fix it before the commit.

uriel.k added inline comments.Nov 8 2017, 6:31 AM
lib/Headers/avx512vlbwintrin.h
2801

I meant of course for all the lines that moved

This revision is now accepted and ready to land.Nov 10 2017, 10:18 PM
This revision was automatically updated to reflect the committed changes.