[MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017
ClosedPublic

Authored by rnk on Fri, Oct 6, 1:52 PM.

Details

Summary

This raises our default past 1900, which controls whether char16_t is a
builtin type or not.

Implements PR34243

Diff Detail

Repository
rL LLVM
rnk created this revision.Fri, Oct 6, 1:52 PM
thakis accepted this revision.Fri, Oct 6, 1:55 PM
thakis added a subscriber: thakis.

Thanks!

Should probably get a release note too.

This revision is now accepted and ready to land.Fri, Oct 6, 1:55 PM
rnk updated this revision to Diff 118079.Fri, Oct 6, 2:02 PM
  • go to 1911, 1910 was the preview
  • add release notes
This revision was automatically updated to reflect the committed changes.

FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update.

rnk added a comment.Mon, Oct 9, 11:51 AM

FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update.

Yep. The initial draft of this patch had the wrong commit message, but everything is fixed in the committed version.

I had 1910 installed on my machine locally, and spent this morning untangling that. Apparently now you have to install updates through the VS "Tools -> Extesions & Updates -> mumble" menu. Downloading and running the VS update 3 installer isn't enough.