This is an archive of the discontinued LLVM Phabricator instance.

[test] Fix append_path in the empty case
ClosedPublic

Authored by fjricci on Oct 4 2017, 7:54 AM.

Details

Summary

normpath() was being called on an empty string and appended to
the environment variable in the case where the environment variable
was unset. This led to ":." being appended to the path, since
normpath() of an empty string is '.', presumably to represent cwd.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci created this revision.Oct 4 2017, 7:54 AM
fjricci edited the summary of this revision. (Show Details)Oct 4 2017, 8:15 AM
fjricci retitled this revision from [test] Fix ASAN_OPTIONS to prevent adding trailing semicolon to [test] Fix ASAN_OPTIONS to prevent adding trailing colon.
fjricci planned changes to this revision.Oct 4 2017, 9:32 AM
fjricci updated this revision to Diff 117685.Oct 4 2017, 9:39 AM
fjricci retitled this revision from [test] Fix ASAN_OPTIONS to prevent adding trailing colon to [test] Fix append_path in the empty case.
fjricci edited the summary of this revision. (Show Details)

fix append_path

zturner accepted this revision.Oct 4 2017, 9:48 AM
This revision is now accepted and ready to land.Oct 4 2017, 9:48 AM
This revision was automatically updated to reflect the committed changes.