test-suite: add cpu architecture detection in cmake configuration

[itaraban]

Summary

This patch adds opportunity to identify cpu target using cpuid, when you use cmake configuration. Then this CPU_ARCH variable can be used for adding options, disabling or enabling tests for given cpu architectures.

Patch with similar feature for make+configure approach -D38182.

[MatzeB]

This seems to be all x86 specific, so I think you should have x86 in the names of CPU_ARCH, DetectCPUArchitecture.c and detect_cpu_architecture.

[MatzeB]

cmake/modules/DetectCPUArchitecture.c

1–4 ↗

(On Diff #117454)

Those are system includes, better use #include <>.

6 ↗

(On Diff #117454)

Add a space after () to match llvm coding style.

15–18 ↗

(On Diff #117454)

Maybe move the variable declarations up so this becomes compilable in C89 as well? (try_run doesn't seem to give any C99 guarantees even though it probably works fine with most compilers).

15–18 ↗

(On Diff #117454)

Would be neat to add a comment with a reference to the Intel documentation on how to interpret the cpuid bits.

20–23 ↗

(On Diff #117454)

According to LLVM coding style cases are not indented further.

100 ↗

(On Diff #117454)

should we return 1 in the unknown case?

104 ↗

(On Diff #117454)

LLVM coding style would use

} else {

here.

132–133 ↗

(On Diff #117454)

see above.

134 ↗

(On Diff #117454)

should we return 1 in the unknown case?

[itaraban]

Sorry for late response. Thanks for your remarks. I changed names and formated DetectX86CPUArchitecture.c.
Soon I'll create review with first cpu-specific tests.

[itaraban]

Patch which uses this feature: D41249

[MatzeB]

LGTM

[itaraban]

Fixed typo in main CMakeLists.txt

CMakeLists.txt

 if(NOT DEFINED TARGET_OS)
   message(STATUS "Check target operating system - ${CMAKE_SYSTEM_NAME}")
   set(TARGET_OS ${CMAKE_SYSTEM_NAME})
 endif()
 if(NOT DEFINED ARCH)
   include(DetectArchitecture)
   detect_architecture(ARCH)
 endif()
+if(NOT DEFINED X86CPU_ARCH AND ARCH STREQUAL "x86")
+  include(DetectArchitecture)
+  detect_x86_cpu_architecture(X86CPU_ARCH)
+endif()
 if(NOT DEFINED ENDIAN)
   include(TestBigEndian)
   test_big_endian(IS_BIGENDIAN)
   if(IS_BIGENDIAN)
     set(ENDIAN "big")
   else()
     set(ENDIAN "little")
   endif()

cmake/modules/DetectArchitecture.cmake

if(DETECT_ARCH_STRING)
         message(SEND_ERROR "Could not detect target system architecture!")
       endif()
     else()
       message(SEND_ERROR "Could not detect target system architecture!")
     endif()
   else()
     message(STATUS "Determine the system architecture - failed")
     file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log
-      "Determining the system architecture fialed with the following output:\n${OUTPUT}")
+      "Determining the system architecture failed with the following output:\n${OUTPUT}")
     set(${variable})
   endif()
   
-endmacro(detect_architecture)
+endmacro(detect_architecture)
+
+#
+# Performs a try_run to determine the cpu architecture of target
+#
+
+macro(detect_x86_cpu_architecture variable)
+  try_run(HAVE_RUN_${variable} HAVE_COMPILE_${variable}
+    ${CMAKE_BINARY_DIR}
+    ${CMAKE_SOURCE_DIR}/cmake/modules/DetectX86CPUArchitecture.c
+    COMPILE_OUTPUT_VARIABLE COMP_OUTPUT
+    RUN_OUTPUT_VARIABLE RUN_OUTPUT)
+
+  if(HAVE_COMPILE_${variable} AND NOT (HAVE_RUN_${variable} STREQUAL  FAILED_TO_RUN))
+    if(RUN_OUTPUT)
+      message(STATUS "Check target system architecture: ${RUN_OUTPUT}")
+      set(${variable} ${RUN_OUTPUT})
+    else()
+      message(SEND_ERROR "Could not detect target system cpu architecture!")
+    endif()
+  else()
+    message(STATUS "Determine the system cpu architecture - failed")
+    file(APPEND ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeError.log
+      "Determining the system cpu architecture failed with the following output:\n${COMP_OUTPUT}\n${RUN_OUTPUT}")
+    set(${variable})
+  endif()
+
+endmacro(detect_x86_cpu_architecture)
+

cmake/modules/DetectX86CPUArchitecture.c

+#include <cpuid.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+int main() {
+  int regs[4] = {0};
+  char vendor[13];
+  __cpuid(0, regs[0], regs[1], regs[2], regs[3]);
+  memcpy(vendor, &regs[1], 4);
+  memcpy(vendor + 4, &regs[3], 4);
+  memcpy(vendor + 8, &regs[2], 4);
+  vendor[12] = '\0';
+  __cpuid(1, regs[0], regs[1], regs[2], regs[3]);
+  short model = (regs[0] >> 4) & 0xF;
+  short family = (regs[0] >> 8) & 0xF;
+  short ext_model = (regs[0] >> 16) & 0xF;
+  short ext_family = (regs[0] >> 20) & 0xFF;
+  switch (family) {
+  case 15:
+    family += ext_family;
+  case 6:
+    model += ext_model << 4;
+  }
+  if (strcmp(vendor, "GenuineIntel") == 0) {
+    switch (family) {
+    case 6:
+      switch (model) {
+      case 87:
+        printf("knl");
+        break;
+      case 92:
+        printf("goldmont");
+        break;
+      case 90:
+      case 76:
+        printf("silvermont");
+        break;
+      case 142:
+      case 158:
+        printf("kaby-lake");
+        break;
+      case 85:
+        printf("skylake-avx512");
+        break;
+      case 78:
+      case 94:
+        printf("skylake");
+        break;
+      case 61:
+      case 71:
+      case 79:
+      case 86:
+        printf("broadwell");
+        break;
+      case 60:
+      case 69:
+      case 70:
+      case 63:
+        printf("haswell");
+        break;
+      case 58:
+      case 62:
+        printf("ivy-bridge");
+        break;
+      case 42:
+      case 45:
+        printf("sandy-bridge");
+        break;
+      case 37:
+      case 44:
+      case 47:
+        printf("westmere");
+        break;
+      case 26:
+      case 30:
+      case 31:
+      case 46:
+        printf("nehalem");
+        break;
+      case 23:
+      case 29:
+        printf("penryn");
+        break;
+      case 15:
+        printf("merom");
+        break;
+      case 28:
+        printf("atom");
+        break;
+      case 14:
+        printf("core");
+        break;
+      }
+      break;
+    case 7:
+      printf("itanium");
+      break;
+    default:
+      printf("unknown");
+      return 1;
+    }
+  } else {
+    if (strcmp(vendor, "AuthenticAMD") == 0) {
+      switch (family) {
+      case 23:
+        printf("zen");
+        break;
+      case 22:
+        printf("16h");
+        break;
+      case 21:
+        if (model < 2)
+          printf("bulldozer");
+        else
+          printf("piledriver");
+        break;
+      case 20:
+        printf("14h");
+        break;
+      case 16:
+        printf("barcelona");
+        break;
+      case 15:
+        printf("k8");
+        break;
+      default:
+        printf("unknown");
+        return 1;
+      }
+    } else {
+      printf("unknown!");
+      return 1;
+    }
+  }
+  return 0;
+}