Page MenuHomePhabricator

eladcohen (Elad Cohen)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 17 2016, 7:24 AM (173 w, 4 d)

Recent Activity

Sep 25 2017

eladcohen added a reviewer for D38182: test-suite: add cpu features detection in configuration: MatzeB.
Sep 25 2017, 5:03 AM

Sep 17 2017

eladcohen added a comment to D37959: [lnt] Allow `lnt importreport` to import hash and profile metrics..

Thanks for the review!

Sep 17 2017, 12:07 PM
eladcohen committed rL313496: [lnt] Allow `lnt importreport` to import hash and profile metrics..
[lnt] Allow `lnt importreport` to import hash and profile metrics.
Sep 17 2017, 12:05 PM
eladcohen closed D37959: [lnt] Allow `lnt importreport` to import hash and profile metrics. by committing rL313496: [lnt] Allow `lnt importreport` to import hash and profile metrics..
Sep 17 2017, 12:05 PM
eladcohen created D37959: [lnt] Allow `lnt importreport` to import hash and profile metrics..
Sep 17 2017, 1:14 AM

Aug 20 2017

eladcohen added a comment to D36933: [buildbot] r310913 was missing a comma in the nt_flags config..

Committed.
It was my fault. Thanks again Victor! sorry for the hassle

Aug 20 2017, 3:38 AM
eladcohen committed rL311282: [buildbot] r310913 was missing a comma in the nt_flags config..
[buildbot] r310913 was missing a comma in the nt_flags config.
Aug 20 2017, 3:36 AM
eladcohen closed D36933: [buildbot] r310913 was missing a comma in the nt_flags config. by committing rL311282: [buildbot] r310913 was missing a comma in the nt_flags config..
Aug 20 2017, 3:36 AM
eladcohen created D36933: [buildbot] r310913 was missing a comma in the nt_flags config..
Aug 20 2017, 3:32 AM
eladcohen added a comment to rL310913: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..

That would be great - thank you!

Aug 20 2017, 12:49 AM
eladcohen removed 1 auditor(s) for rL310913: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder.: vleschuk.
Aug 20 2017, 12:43 AM
eladcohen added 1 auditor(s) for rL310913: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder.: vleschuk.

@vleschuk Hi Victor. Are there any planned restart/reconifg of the staging buildmaster in the near future?
Thanks, Elad

Aug 20 2017, 12:42 AM

Aug 17 2017

eladcohen added a comment to D36651: [SelectionDAG] Teach the vector-types operand scalarizer about SETCC.

Thanks for the review! committed in r311071

Aug 17 2017, 1:09 AM
eladcohen committed rL311071: [SelectionDAG] Teach the vector-types operand scalarizer about SETCC.
[SelectionDAG] Teach the vector-types operand scalarizer about SETCC
Aug 17 2017, 1:08 AM
eladcohen closed D36651: [SelectionDAG] Teach the vector-types operand scalarizer about SETCC by committing rL311071: [SelectionDAG] Teach the vector-types operand scalarizer about SETCC.
Aug 17 2017, 1:08 AM

Aug 15 2017

eladcohen added a comment to D36730: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..

Thanks for the review! committed in r310913.

Aug 15 2017, 4:25 AM
eladcohen committed rL310913: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..
[buildbot] Raise the test-suite runtime limit for the avx512-sde builder.
Aug 15 2017, 4:25 AM
eladcohen closed D36730: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder. by committing rL310913: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..
Aug 15 2017, 4:25 AM
eladcohen created D36730: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..
Aug 15 2017, 1:26 AM

Aug 14 2017

eladcohen updated the diff for D36651: [SelectionDAG] Teach the vector-types operand scalarizer about SETCC.

Fixed Simon's comments.

Aug 14 2017, 2:05 PM
eladcohen committed rL310833: Another attempt to fix the env issue for the avx512-sde bot.
Another attempt to fix the env issue for the avx512-sde bot
Aug 14 2017, 5:11 AM
eladcohen committed rL310828: [SelectionDAG] combine vextract (v1iX extract_subvector(vNiX, Idx)).
[SelectionDAG] combine vextract (v1iX extract_subvector(vNiX, Idx))
Aug 14 2017, 3:50 AM
eladcohen closed D36571: [DAGCombiner] combine vextract (v1iX extract_subvector(vNiX, Idx)) into vextract(vNiX,Idx). by committing rL310828: [SelectionDAG] combine vextract (v1iX extract_subvector(vNiX, Idx)).
Aug 14 2017, 3:50 AM
eladcohen reopened D35788: [DAGCombiner] Extending pattern detection for vector shuffle..

Reopening as it was reverted at rL310822 due to PR34175.

Aug 14 2017, 2:14 AM
eladcohen committed rL310822: Revert "[DAGCombiner] Extending pattern detection for vector shuffle….
Revert "[DAGCombiner] Extending pattern detection for vector shuffle…
Aug 14 2017, 2:07 AM
eladcohen updated the diff for D36571: [DAGCombiner] combine vextract (v1iX extract_subvector(vNiX, Idx)) into vextract(vNiX,Idx)..

Fixed Simon's comments. Thanks for the review!

Aug 14 2017, 1:36 AM

Aug 13 2017

eladcohen updated the diff for D36571: [DAGCombiner] combine vextract (v1iX extract_subvector(vNiX, Idx)) into vextract(vNiX,Idx)..

Fixed Simon's comments.

Aug 13 2017, 8:10 AM
eladcohen added inline comments to D36571: [DAGCombiner] combine vextract (v1iX extract_subvector(vNiX, Idx)) into vextract(vNiX,Idx)..
Aug 13 2017, 8:10 AM
eladcohen created D36651: [SelectionDAG] Teach the vector-types operand scalarizer about SETCC.
Aug 13 2017, 6:55 AM

Aug 10 2017

eladcohen created D36571: [DAGCombiner] combine vextract (v1iX extract_subvector(vNiX, Idx)) into vextract(vNiX,Idx)..
Aug 10 2017, 1:54 AM
eladcohen committed rL310552: [SelectionDAG] When scalarizing vselect, don't assert on.
[SelectionDAG] When scalarizing vselect, don't assert on
Aug 10 2017, 12:45 AM
eladcohen closed D36511: [SelectionDAG] When scalarizing vselect, don't assert on a legal cond operand. by committing rL310552: [SelectionDAG] When scalarizing vselect, don't assert on.
Aug 10 2017, 12:45 AM

Aug 9 2017

eladcohen updated the diff for D36511: [SelectionDAG] When scalarizing vselect, don't assert on a legal cond operand..

Fixed Simon's comment.

Aug 9 2017, 8:08 AM
eladcohen added a comment to D36511: [SelectionDAG] When scalarizing vselect, don't assert on a legal cond operand..

LGTM, with one minor.

PS - nothing to do with this patch but those mask vector shifts are awful.

Aug 9 2017, 8:07 AM
eladcohen created D36511: [SelectionDAG] When scalarizing vselect, don't assert on a legal cond operand..
Aug 9 2017, 4:51 AM

Jul 29 2017

eladcohen committed rL309491: Fix the env PATH var for the avx512-sde bot.
Fix the env PATH var for the avx512-sde bot
Jul 29 2017, 11:29 AM

Jul 27 2017

eladcohen added a comment to D35939: Add an x86-64 LNT perf builder.

Thanks for the review! committed in r309275.

Jul 27 2017, 8:01 AM
eladcohen committed rL309275: Add an X86-64 AVX2 LNT perf builder..
Add an X86-64 AVX2 LNT perf builder.
Jul 27 2017, 8:01 AM
eladcohen closed D35939: Add an x86-64 LNT perf builder by committing rL309275: Add an X86-64 AVX2 LNT perf builder..
Jul 27 2017, 8:00 AM
eladcohen created D35939: Add an x86-64 LNT perf builder.
Jul 27 2017, 5:58 AM

Jul 22 2017

eladcohen committed rL308829: Fix X86-64 SDE builder config..
Fix X86-64 SDE builder config.
Jul 22 2017, 12:35 PM
eladcohen closed D35660: Fix X86-64 SDE builder config by committing rL308829: Fix X86-64 SDE builder config..
Jul 22 2017, 12:35 PM

Jul 20 2017

eladcohen updated the diff for D35660: Fix X86-64 SDE builder config.
Jul 20 2017, 12:43 AM
eladcohen created D35660: Fix X86-64 SDE builder config.
Jul 20 2017, 12:25 AM

Jul 19 2017

eladcohen added a comment to D35580: Add an X86 with SDE clang builder and slave.

thanks for the review! committed in r308516.

Jul 19 2017, 1:02 PM
eladcohen committed rL308516: Add an X86-64 with SDE clang builder and slave.
Add an X86-64 with SDE clang builder and slave
Jul 19 2017, 1:02 PM
eladcohen closed D35580: Add an X86 with SDE clang builder and slave by committing rL308516: Add an X86-64 with SDE clang builder and slave.
Jul 19 2017, 1:02 PM

Jul 18 2017

eladcohen created D35580: Add an X86 with SDE clang builder and slave.
Jul 18 2017, 1:42 PM

Jul 12 2017

eladcohen closed D35199: Add an X86 AVX2 clang builder and slave.

Committed in r307753.

Jul 12 2017, 10:08 PM

Jul 11 2017

eladcohen added a comment to D35199: Add an X86 AVX2 clang builder and slave.

Thanks for the review.
Committed in r307753.

Jul 11 2017, 10:10 PM
eladcohen committed rL307753: Add an X86-64 AVX2 clang builder and slave.
Add an X86-64 AVX2 clang builder and slave
Jul 11 2017, 10:09 PM

Jul 10 2017

eladcohen updated the diff for D35199: Add an X86 AVX2 clang builder and slave.
  • Removed the duplicate number of jobs specification.
  • Removed the unrelated whitespace changes.
Jul 10 2017, 11:30 PM
eladcohen added inline comments to D35199: Add an X86 AVX2 clang builder and slave.
Jul 10 2017, 8:19 AM
eladcohen created D35199: Add an X86 AVX2 clang builder and slave.
Jul 10 2017, 6:13 AM

Jun 1 2017

eladcohen committed rL304395: Resubmit r303853.
Resubmit r303853
Jun 1 2017, 1:09 AM

May 29 2017

eladcohen committed rL304169: Revert r303853.
Revert r303853
May 29 2017, 11:40 AM

May 25 2017

eladcohen added a comment to D33544: [lnt][profile] Add support for X86-64 CFG view.

Thanks for the review!
Committed in r303853

May 25 2017, 6:14 AM
eladcohen committed rL303853: [lnt][profile] Add support for X86-64 CFG view.
[lnt][profile] Add support for X86-64 CFG view
May 25 2017, 6:13 AM
eladcohen closed D33544: [lnt][profile] Add support for X86-64 CFG view by committing rL303853: [lnt][profile] Add support for X86-64 CFG view.
May 25 2017, 6:13 AM
eladcohen updated the diff for D33544: [lnt][profile] Add support for X86-64 CFG view.

Fixed Kristof's comment - Thanks!

May 25 2017, 6:00 AM
eladcohen updated the diff for D33544: [lnt][profile] Add support for X86-64 CFG view.
May 25 2017, 5:18 AM
eladcohen created D33544: [lnt][profile] Add support for X86-64 CFG view.
May 25 2017, 5:09 AM

May 3 2017

eladcohen added a comment to D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics.

Thanks for the review! Committed r302018

May 3 2017, 5:43 AM
eladcohen committed rL302018: Support arbitrary address space pointers in masked gather/scatter intrinsics..
Support arbitrary address space pointers in masked gather/scatter intrinsics.
May 3 2017, 5:42 AM
eladcohen closed D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics by committing rL302018: Support arbitrary address space pointers in masked gather/scatter intrinsics..
May 3 2017, 5:42 AM

Apr 19 2017

eladcohen updated the diff for D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics.

Fixed Elena's comment.

Apr 19 2017, 7:16 AM
eladcohen updated the diff for D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics.

Fixed Zvi's comment (Added a non-default addrspace example to the LangRef)

Apr 19 2017, 4:41 AM
eladcohen added a comment to D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics.
In D31490#730229, @zvi wrote:

I might have missed something, but all the examples in the langref and test-cases include only pointers to addspace(0). Maybe change/add tests and example to include non-zero address-spaces?

Apr 19 2017, 4:30 AM
eladcohen updated the diff for D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics.

Fixed Elena's comments.

Apr 19 2017, 12:34 AM

Apr 18 2017

eladcohen added reviewers for D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics: apilipenko, RKSimon, craig.topper.
Apr 18 2017, 11:17 PM

Mar 30 2017

eladcohen added a reviewer for D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics: zvi.
Mar 30 2017, 1:48 AM
eladcohen created D31490: Support arbitrary address space pointers in masked gather/scatter intrinsics.
Mar 30 2017, 1:41 AM

Mar 25 2017

eladcohen added a reviewer for D29599: Clang Changes for alloc_align: aaron.ballman.
Mar 25 2017, 10:58 PM

Feb 22 2017

eladcohen accepted D30194: DAZ Macros Relocation.

LGTM

Feb 22 2017, 1:42 AM

Jan 18 2017

eladcohen updated the diff for D28558: [CMake] Ignore hidden/metadata files when adding lit check-* testsuites.

Fixed Michał's comment

Jan 18 2017, 1:35 AM
eladcohen added inline comments to D28558: [CMake] Ignore hidden/metadata files when adding lit check-* testsuites.
Jan 18 2017, 1:34 AM

Jan 17 2017

eladcohen added a reviewer for D28558: [CMake] Ignore hidden/metadata files when adding lit check-* testsuites: mgorny.
Jan 17 2017, 7:08 AM

Jan 11 2017

eladcohen closed D28550: [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1 mask.
Jan 11 2017, 11:06 PM
eladcohen added a comment to D28550: [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1 mask.

Thanks for the review!
Committed in r291745.

Jan 11 2017, 11:06 PM
eladcohen committed rL291745: [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1….
[X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1…
Jan 11 2017, 11:00 PM
eladcohen added inline comments to D28550: [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1 mask.
Jan 11 2017, 9:56 PM
eladcohen retitled D28558: [CMake] Ignore hidden/metadata files when adding lit check-* testsuites from to [CMake] Ignore hidden/metadata files when adding lit check-* testsuites.
Jan 11 2017, 4:37 AM
eladcohen retitled D28550: [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1 mask from to [X86][AVX512] Fix PR31515 - Do not flip vselect condition if it's not a vXi1 mask.
Jan 11 2017, 2:29 AM
eladcohen added a comment to D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.

Thanks for the review! committed r291660

Jan 11 2017, 1:24 AM
eladcohen committed rL291660: [X86] Fix PR30926 - Add patterns for (v)cvtsi2s{s,d} and (v)cvtsd2s{s,d}.
[X86] Fix PR30926 - Add patterns for (v)cvtsi2s{s,d} and (v)cvtsd2s{s,d}
Jan 11 2017, 1:22 AM
eladcohen closed D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences by committing rL291660: [X86] Fix PR30926 - Add patterns for (v)cvtsi2s{s,d} and (v)cvtsd2s{s,d}.
Jan 11 2017, 1:22 AM

Jan 10 2017

eladcohen updated the diff for D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.

Fixed Craig's comments.

Jan 10 2017, 11:21 PM
eladcohen updated the diff for D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.

Thanks for the pointers!
Added AVX512 patterns

Jan 10 2017, 10:58 PM

Jan 9 2017

eladcohen updated the diff for D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.

Changed patterns order.

Jan 9 2017, 5:49 AM
eladcohen added inline comments to D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.
Jan 9 2017, 5:42 AM
eladcohen retitled D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences from [X86] Fix PR30926 - Add patterns for optimizing cvtsi2ss, cvtsi2sd, and cvtss2sd clang intrinsic sequences to [X86] Fix PR30926 - Add patterns for optimizing cvtsi2ss, cvtsi2sd, cvtsd2ss and cvtss2sd clang intrinsic sequences.
Jan 9 2017, 12:56 AM
eladcohen updated the diff for D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.

Added patterns for (v)cvtsd2ss

Jan 9 2017, 12:56 AM

Jan 8 2017

eladcohen added a comment to D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences.

Doesn't (v)cvtsd2ss suffer from the same issue as well?

Jan 8 2017, 10:44 PM

Jan 7 2017

eladcohen retitled D28455: [X86] Fix PR30926 - Add patterns for optimizing (v)cvtsi2ss, (v)cvtsi2sd, (v)cvtsd2ss and (v)cvtss2sd clang intrinsic sequences from to [X86] Fix PR30926 - Add patterns for optimizing cvtsi2ss, cvtsi2sd, and cvtss2sd clang intrinsic sequences.
Jan 7 2017, 10:47 PM

Jan 3 2017

eladcohen added a comment to D27897: [Modules] Enable the Modules language feature by default for the Clang builtins. .

ping

Jan 3 2017, 10:38 PM

Dec 17 2016

eladcohen retitled D27897: [Modules] Enable the Modules language feature by default for the Clang builtins. from to [Modules] Enable the Modules language feature by default for the Clang builtins. .
Dec 17 2016, 10:56 PM
eladcohen retitled D27896: Remove the feature guards from the Clang intrinsics header files. from to Remove the feature guards from the Clang intrinsics header files. .
Dec 17 2016, 10:39 PM

Oct 31 2016

eladcohen added a comment to D25767: [Modules] Add a command line option for loading the clang builtins modulemap file..

Thanks for the review! committed r285548.

Oct 31 2016, 1:33 AM
eladcohen committed rL285548: [Modules] Add a command line option for loading the clang builtins modulemap..
[Modules] Add a command line option for loading the clang builtins modulemap.
Oct 31 2016, 1:31 AM
eladcohen closed D25767: [Modules] Add a command line option for loading the clang builtins modulemap file. by committing rL285548: [Modules] Add a command line option for loading the clang builtins modulemap..
Oct 31 2016, 1:31 AM