Details
Details
Diff Detail
Diff Detail
- Repository
- rOLDT svn-test-suite
Event Timeline
Comment Actions
I didn't really read all the tests in detail, but from a high level this looks fine.
SingleSource/UnitTests/Vector/AVX512/minmax_shift.c | ||
---|---|---|
1151–1157 | This pattern repeats in every test, why not put it into a function? And to be nitpicky I think printing FAILED/PASSED is unnecessary: In the PASSED case it's perfectly fine to print nothing and return 0 IMO, in the FAILED case you should have already seen an error message anyway. |
This pattern repeats in every test, why not put it into a function?
And to be nitpicky I think printing FAILED/PASSED is unnecessary: In the PASSED case it's perfectly fine to print nothing and return 0 IMO, in the FAILED case you should have already seen an error message anyway.