Page MenuHomePhabricator

[AsmParser] Support GAS's .print directive
ClosedPublic

Authored by coby on Oct 1 2017, 1:23 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

coby created this revision.Oct 1 2017, 1:23 PM
coby updated this revision to Diff 117293.Oct 1 2017, 1:28 PM
javed.absar added inline comments.
lib/MC/MCParser/AsmParser.cpp
542 ↗(On Diff #117293)

Putting DK_PRINT beyond DK_END doesn't seem right

coby added inline comments.Oct 1 2017, 5:07 PM
lib/MC/MCParser/AsmParser.cpp
542 ↗(On Diff #117293)

ah.. DK_END stands for the ".end" directive and holds no other semantical purposes.. but I can see your point :)
will be relocated.
anything else other than this?

javed.absar added inline comments.Oct 2 2017, 6:07 AM
lib/MC/MCParser/AsmParser.cpp
542 ↗(On Diff #117293)

OK from my side. Thanks.

mcrosier accepted this revision.Oct 2 2017, 6:28 AM
mcrosier added a subscriber: mcrosier.

LGTM.

This revision is now accepted and ready to land.Oct 2 2017, 6:28 AM

LGTM.

(Assuming the enum ordering is addressed, of course.)

coby added a comment.Oct 2 2017, 6:44 AM

thanks for the prompt review.
will address enum's values definition ordering upon the commit itself

This revision was automatically updated to reflect the committed changes.