Its PR34712,
GNU linkers recently changed default values to "both" of "sysv".
It seems reasonable for me to do the same in LLD,
patch do the same for all targets except MIPS, where .gnu.hash
section is not yet supported.
Paths
| Differential D38407
[ELF] - Do --hash-style=both by default. ClosedPublic Authored by grimar on Sep 29 2017, 8:31 AM.
Details Summary Its PR34712, GNU linkers recently changed default values to "both" of "sysv".
Diff Detail
Event TimelineHerald added subscribers: kbarton, arichardson, javed.absar and 4 others. · View Herald TranscriptSep 29 2017, 8:31 AM Comment Actions Could you start a thread in the mailing list to propose a change of the default settings first then create a patch? I don't want you to update that many tests (which probably needed a lot of labor work) before getting any consensus, even if reaching a consensus is obvious to you. A rule of thumb is that, code review is not a place to discuss policy changes. Comment Actions
Comment Actions Please do *not* update a patch until you declare we reach an conclusion in the discussion thread.
Comment Actions
Comment Actions I created https://reviews.llvm.org/D38573 to show you what I meant by my previous comment. Please apply it to your patch. Basically, if you want to name a function "finalize", it is likely a sign that that is not a good name nor a good function. It just says "it runs at last" and doesn't really explain what the function does. Such function is easy to become a kitchen sink. So, if you try to name your function "finalize" next time, you probably should stop and think about what your function actually does. In most cases, you shouldn't name a function "finalize". This revision is now accepted and ready to land.Oct 5 2017, 11:47 AM Closed by commit rL315051: [ELF] - Do --hash-style=both by default. (authored by grimar). · Explain WhyOct 6 2017, 2:39 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 117966 lld/trunk/ELF/Config.h
lld/trunk/ELF/Driver.cpp
lld/trunk/test/ELF/aarch64-gnu-ifunc-plt.s
lld/trunk/test/ELF/aarch64-got-relocations.s
lld/trunk/test/ELF/aarch64-tls-gdie.s
lld/trunk/test/ELF/aarch64-tls-ie.s
lld/trunk/test/ELF/aarch64-tls-static.s
lld/trunk/test/ELF/aarch64-tlsdesc.s
lld/trunk/test/ELF/abs-hidden.s
lld/trunk/test/ELF/amdgpu-relocs.s
lld/trunk/test/ELF/arm-copy.s
lld/trunk/test/ELF/arm-exidx-shared.s
lld/trunk/test/ELF/arm-gnu-ifunc-plt.s
lld/trunk/test/ELF/arm-got-relative.s
lld/trunk/test/ELF/arm-pie-relative.s
lld/trunk/test/ELF/arm-plt-reloc.s
lld/trunk/test/ELF/arm-thumb-plt-reloc.s
lld/trunk/test/ELF/arm-tls-gd-nonpreemptible.s
lld/trunk/test/ELF/arm-tls-gd32.s
lld/trunk/test/ELF/arm-tls-ie32.s
lld/trunk/test/ELF/arm-tls-ldm32.s
lld/trunk/test/ELF/arm-tls-norelax-gd-ie.s
lld/trunk/test/ELF/arm-tls-norelax-gd-le.s
lld/trunk/test/ELF/arm-tls-norelax-ie-le.s
lld/trunk/test/ELF/arm-tls-norelax-ld-le.s
lld/trunk/test/ELF/basic-ppc.s
lld/trunk/test/ELF/copy-rel-pie.s
lld/trunk/test/ELF/dynamic-got.s
lld/trunk/test/ELF/dynamic-list-preempt.s
lld/trunk/test/ELF/dynamic-list.s
lld/trunk/test/ELF/dynamic-reloc.s
lld/trunk/test/ELF/eh-align-cie.s
lld/trunk/test/ELF/eh-frame-hdr-augmentation.s
lld/trunk/test/ELF/eh-frame-merge.s
lld/trunk/test/ELF/eh-frame-padding-no-rosegment.s
lld/trunk/test/ELF/emit-relocs-shared.s
lld/trunk/test/ELF/global-offset-table-position-aarch64.s
lld/trunk/test/ELF/global-offset-table-position-arm.s
lld/trunk/test/ELF/global-offset-table-position-i386.s
lld/trunk/test/ELF/global-offset-table-position.s
lld/trunk/test/ELF/global_offset_table_shared.s
lld/trunk/test/ELF/gnu-ifunc-gotpcrel.s
lld/trunk/test/ELF/gnu-ifunc-plt-i386.s
lld/trunk/test/ELF/gnu-ifunc-plt.s
lld/trunk/test/ELF/gnu-ifunc-shared.s
lld/trunk/test/ELF/got-aarch64.s
lld/trunk/test/ELF/got.s
lld/trunk/test/ELF/gotpc-relax-nopic.s
lld/trunk/test/ELF/gotpc-relax-und-dso.s
lld/trunk/test/ELF/gotpcrelx.s
lld/trunk/test/ELF/i386-got-and-copy.s
lld/trunk/test/ELF/i386-gotoff-shared.s
lld/trunk/test/ELF/i386-gotpc-dynamic.s
lld/trunk/test/ELF/i386-gotpc.s
lld/trunk/test/ELF/i386-tls-ie-shared.s
lld/trunk/test/ELF/icf-symbol-type.s
lld/trunk/test/ELF/linkerscript/data-segment-relro.s
lld/trunk/test/ELF/linkerscript/emit-reloc.s
lld/trunk/test/ELF/linkerscript/extend-pt-load.s
lld/trunk/test/ELF/linkerscript/header-addr.s
lld/trunk/test/ELF/linkerscript/implicit-program-header.s
lld/trunk/test/ELF/linkerscript/no-space.s
lld/trunk/test/ELF/linkerscript/non-alloc.s
lld/trunk/test/ELF/linkerscript/orphan-report.s
lld/trunk/test/ELF/linkerscript/out-of-order.s
lld/trunk/test/ELF/linkerscript/repsection-symbol.s
lld/trunk/test/ELF/linkerscript/sections-sort.s
lld/trunk/test/ELF/linkerscript/segment-start.s
lld/trunk/test/ELF/linkerscript/sort-non-script.s
lld/trunk/test/ELF/local-got-pie.s
lld/trunk/test/ELF/local-got-shared.s
lld/trunk/test/ELF/local-got.s
lld/trunk/test/ELF/noplt-pie.s
lld/trunk/test/ELF/pie-weak.s
lld/trunk/test/ELF/pr34660.s
lld/trunk/test/ELF/relocation-copy-alias.s
lld/trunk/test/ELF/relocation-copy-align-common.s
lld/trunk/test/ELF/relocation-copy-flags.s
lld/trunk/test/ELF/relocation-copy-relro.s
lld/trunk/test/ELF/relocation-i686.s
lld/trunk/test/ELF/relocation.s
lld/trunk/test/ELF/relro-omagic.s
lld/trunk/test/ELF/resolution-end.s
lld/trunk/test/ELF/retain-symbols-file.s
lld/trunk/test/ELF/shared.s
lld/trunk/test/ELF/sort-norosegment.s
lld/trunk/test/ELF/startstop.s
lld/trunk/test/ELF/synthetic-got.s
lld/trunk/test/ELF/tls-dynamic-i686.s
lld/trunk/test/ELF/tls-dynamic.s
lld/trunk/test/ELF/tls-got.s
lld/trunk/test/ELF/tls-i686.s
lld/trunk/test/ELF/tls-initial-exec-local.s
lld/trunk/test/ELF/tls-opt-gdie.s
lld/trunk/test/ELF/tls-opt-gdiele-i686.s
lld/trunk/test/ELF/tls-opt-iele-i686-nopic.s
lld/trunk/test/ELF/tls-two-relocs.s
lld/trunk/test/ELF/verdef-defaultver.s
lld/trunk/test/ELF/verdef.s
lld/trunk/test/ELF/verneed.s
lld/trunk/test/ELF/version-script-extern.s
lld/trunk/test/ELF/version-script.s
lld/trunk/test/ELF/x86-64-relax-got-abs.s
lld/trunk/test/ELF/x86-64-tls-gd-local.s
|