[C++] Parse (sub) postfix expression after boolean literal

[Rakete1111]

Summary

Parses a postfix expression after a boolean literal:

auto x = true["Oh really?"]; // ok

This fixes PR34273.

[aaron.ballman]

test/CXX/expr/expr.post/expr.sub/p1.cpp

3–6 ↗

(On Diff #116917)

I think this test should be added to test/Parser/ instead of CXX; this does not really appertain to [expr.sub]p1, which is more about the semantics than the parsing.

4–5 ↗

(On Diff #116917)

The "expected-no-diagnostics" comment should be right below the RUN line, and you only need it once.

[Rakete1111]

• Moved test to test/CXX/

Do I actually need to -verify the test if no diagnostics are expected?

Thanks @aaron.ballman

[aaron.ballman]

In D38342#883872, @Rakete1111 wrote:

• Moved test to test/CXX/

Do I actually need to -verify the test if no diagnostics are expected?

Thanks @aaron.ballman

Yes, you need to make sure that verify is on the RUN line. The existing test is broken like that (good catch). You should add -verify to the run line and // expected-no-diagnostics below it.

[Rakete1111]

• Fixed test case for bools

Ah got it! Thanks!!

[aaron.ballman]

LGTM! Do you need me to commit on your behalf?

[Rakete1111]

Yes please :) Thanks @aaron.ballman

[aaron.ballman]

Committed in r314463.

Btw, if you're not in the IRC channel (#llvm on OFTC), you should hang out in there to make sure no build bots break due to the commit.

lib/Parse/ParseExpr.cpp

 
   case tok::kw_true:
   case tok::kw_false:
-    return ParseCXXBoolLiteral();
+    Res = ParseCXXBoolLiteral();
+    break;
   
   case tok::kw___objc_yes:
   case tok::kw___objc_no:

test/Parser/cxx-bool.cpp

-// RUN: %clang_cc1 -fsyntax-only %s
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+// expected-no-diagnostics
 
 bool a = true;
 bool b = false;
+
+namespace pr34273 {
+  char c = "clang"[true];
+  char d = true["clang"];
+}
+