This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][Falkor] Fix correctness bug in falkor prefetcher fix pass and correct some opcode tag computations.
ClosedPublic

Authored by gberry on Sep 25 2017, 2:03 PM.

Details

Summary

This addresses a correctness bug for LD[1234]*_POST opcodes that have
the prefetcher fix applied to them: the base register was not being
written back from the temp after being incremented, so it would appear
to never be incremented.

Also, fix some opcode tag computations based on some updated HW details
to get better tag avoidance and thus better prefetcher performance.

Diff Detail

Repository
rL LLVM

Event Timeline

gberry created this revision.Sep 25 2017, 2:03 PM
mcrosier accepted this revision.Sep 26 2017, 1:07 PM

LGTM.

This revision is now accepted and ready to land.Sep 26 2017, 1:07 PM
This revision was automatically updated to reflect the committed changes.