This is an archive of the discontinued LLVM Phabricator instance.

[mips] Remove codegen support for branch likely instructions.
ClosedPublic

Authored by sdardis on Sep 22 2017, 3:30 AM.

Details

Summary

This patch disables codegen support for branch likely instructions to
address a potential bug. These branches were unselectable as
they had the same patterns as the normal branches but came after them
when ISel was concerned.

The branch likely instructions were marked as having no delay
slots when they have annulling delay slots. The delay slot filler
does not currently handle annulling delay slot branches, so this
would lead to wrong codegen if these branches were generated.

Event Timeline

sdardis created this revision.Sep 22 2017, 3:30 AM
This revision is now accepted and ready to land.Sep 25 2017, 1:48 PM
This revision was automatically updated to reflect the committed changes.