[ELF] [fix] Using statically linked lld leads to segmentation fault on linking ELF

[emankov]

Summary

[Synopsys]
Using function elf::link(...) leads to segmentation fault on its second call. First call finishes correctly.

[Solution]
Clear the rest of globals.

[grimar]

ELF/Driver.cpp

83

It probably will not be enough.

For example we have synthetic sections which are statics now, like `InX::DynSymTab'.
Doesn't seem them are cleared properly. If first call uses it and second - don't, it seems
to me it will fail.

So I want to say this change looks fine for me, but problem will not be solved completely anyways I think,

[ruiu]

LGTM

ELF/Driver.cpp

83

It does worth it. You just have to fix all these problems.

ELF/Driver.cpp

 
 static void setConfigs();
 
 bool elf::link(ArrayRef<const char *> Args, bool CanExitEarly,
                raw_ostream &Error) {
   ErrorCount = 0;
   ErrorOS = &Error;
   InputSections.clear();
+  OutputSections.clear();
   Tar = nullptr;
+  BinaryFiles.clear();
+  BitcodeFiles.clear();
+  ObjectFiles.clear();
+  SharedFiles.clear();
 
   Config = make<Configuration>();
   Driver = make<LinkerDriver>();
   Script = make<LinkerScript>();
   Symtab = make<SymbolTable>();
   Config->Argv = {Args.begin(), Args.end()};
 
   Driver->main(Args, CanExitEarly);