This is an archive of the discontinued LLVM Phabricator instance.

[libcxx / lit] Make libcxx work correctly with the new testing workflow
ClosedPublic

Authored by zturner on Sep 18 2017, 2:13 PM.

Details

Summary

Some changes to lit made it so you no longer specify --project_site_param=<path>, and instead you run the llvm-lit script generated into the build directory of your project.

Not all projects had been updated accordingly, and this broke running the test suite in libcxx (among other projects). This patch attempts to get libcxx working correctly. Now, when you do a standalone build, llvm-lit is written into the <build-dir>/bin and contains the necessary mappings so that you can run either a check target or pointing it to a source tree.

Diff Detail

Repository
rL LLVM

Event Timeline

zturner created this revision.Sep 18 2017, 2:13 PM
smeenai edited edge metadata.Sep 18 2017, 2:28 PM

This fixes my use case; thank you! Waiting for @mclow.lists to confirm it works for him too.

llvm/cmake/modules/AddLLVM.cmake
1190 ↗(On Diff #115717)

This seems unrelated? It's definitely useful for debugging though.

zturner added inline comments.Sep 18 2017, 2:30 PM
llvm/cmake/modules/AddLLVM.cmake
1190 ↗(On Diff #115717)

Yea sorry about that. I'll submit this in a followup

mclow.lists accepted this revision.Sep 18 2017, 3:50 PM

Seems to work fine here! LGTM.

This revision is now accepted and ready to land.Sep 18 2017, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Had to revert this because of http://green.lab.llvm.org/green/job/libcxx_master_cmake/670/consoleFull

It's strange, CMake even warns that this is an unsupported libcxx configuration. But I guess it's been working all this time. I will probably need to talk to the bot owner to figure out how to fix this.