should fix https://bugs.llvm.org/show_bug.cgi?id=34403
I think it would good to add a test for the changed functionality.
Looks like I rushed into accepting. This needs a test case of cause!
@dcoughlin that would be OK?
Looks good to me. Thanks for fixing this!
Committed in r313385
Neat! I've seen this code multiple times but never noticed this bug.
There's also the "// no-crash" thingy we write from time to time in order to quickly explain what the test is about.