Page MenuHomePhabricator

[Analyzer] Check function name size before performing indexing
ClosedPublic

Authored by george.karpenkov on Sep 15 2017, 10:53 AM.

Details

Diff Detail

Event Timeline

zaks.anna accepted this revision.Sep 15 2017, 10:57 AM
This revision is now accepted and ready to land.Sep 15 2017, 10:57 AM
dcoughlin edited edge metadata.Sep 15 2017, 11:09 AM

I think it would good to add a test for the changed functionality.

Looks like I rushed into accepting. This needs a test case of cause!

dcoughlin accepted this revision.Sep 15 2017, 11:51 AM

Looks good to me. Thanks for fixing this!

Committed in r313385

NoQ edited edge metadata.Sep 16 2017, 1:18 AM

Neat! I've seen this code multiple times but never noticed this bug.

test/Analysis/retain-release.mm
465

There's also the "// no-crash" thingy we write from time to time in order to quickly explain what the test is about.