This is an archive of the discontinued LLVM Phabricator instance.

[X86] Don't emit COPY_TO_REG to ABCD registers before EXTRACT_SUBREG of sub_8bit_hi
ClosedPublic

Authored by craig.topper on Sep 13 2017, 10:35 PM.

Details

Summary

I'm pretty sure that InstrEmitter::EmitSubregNode will take care of this itself by calling ConstrainForSubReg which in turn calls TRI->getSubClassWithSubReg.

I think Jakob Stoklund Olesen alluded to this in his commit message for r141207 which added the code to EmitSubregNode.

I want to do the same to the sub_8bit patterns too, but I hit a global isel failure.

Diff Detail