Added missing addrspacecast case in alignment computation logic of pointer type emission in IR generation.
Details
Diff Detail
Event Timeline
lib/CodeGen/CGExpr.cpp | ||
---|---|---|
957 | Better assert that only CK_AddressSpaceConversion allows different addr spaces in target type. |
lib/CodeGen/CGExpr.cpp | ||
---|---|---|
957 | It seems for consistency then we would have to assert for both different ASes in non-addrspacecast case and equivalent ASes in the other case. As condition becomes complicated then, I could as well split into either creating bitcast or addrspacecast explicitly at a cost of one simple check in the return statement but that would be in release build too. |
lib/CodeGen/CGExpr.cpp | ||
---|---|---|
957 | Sam, do you prefer an assert that will check both things or a runtime check that would make sure to build the right IR node here? |
lib/CodeGen/CGExpr.cpp | ||
---|---|---|
957 | splitting into bitcast and addrspacecast seems better. |
vectorLoadStore.cl is failing on our bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8187, please check it out
Better assert that only CK_AddressSpaceConversion allows different addr spaces in target type.