Page MenuHomePhabricator

[GlobalISel][X86] G_ANYEXT support.
ClosedPublic

Authored by igorb on Sep 11 2017, 12:46 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb created this revision.Sep 11 2017, 12:46 AM
igorb updated this revision to Diff 114542.Sep 11 2017, 12:51 AM
  • fix copy - paste
delena accepted this revision.Sep 11 2017, 1:46 AM

LGTM, + replace "if"s with "assert"s

lib/Target/X86/X86InstructionSelector.cpp
749 ↗(On Diff #114542)

sizeinbits of AnyExt should be checked on IR level.

743 ↗(On Diff #114540)

I assume that source and dest should be always from the same reg bank. If yes, please put "assert" here. If no, please add a comment in what case it is not handled.

This revision is now accepted and ready to land.Sep 11 2017, 1:46 AM
This revision was automatically updated to reflect the committed changes.