This is an archive of the discontinued LLVM Phabricator instance.

Differential D3764

Improve the scan-build messages
ClosedPublic

Authored by sylvestre.ledru on May 14 2014, 6:44 AM.

Details

Reviewers
• jddupas
krememek
jordan_rose
Summary

Bikeshed!

Diff Detail

Event Timeline

sylvestre.ledru updated this revision to Diff 9390.May 14 2014, 6:44 AM
sylvestre.ledru retitled this revision from to Improve the scan-build messages.
sylvestre.ledru updated this object.
sylvestre.ledru edited the test plan for this revision. (Show Details)
sylvestre.ledru added a parent revision: D3763: List the function/method name in the index page of scan-build .
sylvestre.ledru added reviewers: jordan_rose, krememek, • jddupas.
Jean-Daniel added a subscriber: Jean-Daniel.May 14 2014, 4:05 PM
Jean-Daniel added inline comments.
tools/scan-build/scan-build
873

From the following line ($Num > 0 && …), it looks like the Num bug can also be 0, so instead of '== 1', shouldn't it be <= 1 ?

jordan_rose edited edge metadata.May 14 2014, 8:38 PM

"No bugs found" is correct English for "0 bugs found". "No bug found" implies that there will only ever be 0 or 1. "0 bug found" is just incorrect English.

sylvestre.ledru added a comment.May 14 2014, 11:13 PM

OK. thanks. Sorry about the noise.
However, "1 bug found" is correct, right?

sylvestre.ledru updated this revision to Diff 9441.May 15 2014, 6:54 AM
sylvestre.ledru edited edge metadata.
jordan_rose accepted this revision.May 15 2014, 7:44 AM
jordan_rose edited edge metadata.

Yes, that's correct. Thanks, Sylvestre!

This revision is now accepted and ready to land.May 15 2014, 7:44 AM
sylvestre.ledru closed this revision.May 16 2014, 12:11 AM

Merged in commit r208951

tools/scan-build/scan-build
873

When it is 0, I think we have already left the function

Revision Contents

Diff 9441

tools/scan-build/scan-build

Context not available.
print CalcStats(\@Stats) if $AnalyzerStats; print CalcStats(\@Stats) if $AnalyzerStats;
my $Num = scalar(@Index); my $Num = scalar(@Index);
Diag("$Num bugs found.\n"); if ($Num == 1) {
Diag("$Num bug found.\n");
} else {
Diag("$Num bugs found.\n");
}
Jean-DanielUnsubmitted
Not Done
ReplyInline Actions

From the following line ($Num > 0 && …), it looks like the Num bug can also be 0, so instead of '== 1', shouldn't it be <= 1 ?

Jean-Daniel: From the following line ($Num > 0 && …), it looks like the Num bug can also be 0, so instead of…
sylvestre.ledruAuthorUnsubmitted
Not Done
ReplyInline Actions

When it is 0, I think we have already left the function

sylvestre.ledru: When it is 0, I think we have already left the function
if ($Num > 0 && -r "$Dir/index.html") { if ($Num > 0 && -r "$Dir/index.html") {
Diag("Run 'scan-view $Dir' to examine bug reports.\n"); Diag("Run 'scan-view $Dir' to examine bug reports.\n");
} }
Context not available.