Improve the scan-build messages

[sylvestre.ledru]

Summary

Bikeshed!

[Jean-Daniel]

tools/scan-build/scan-build

873

From the following line ($Num > 0 && …), it looks like the Num bug can also be 0, so instead of '== 1', shouldn't it be <= 1 ?

[jordan_rose]

"No bugs found" is correct English for "0 bugs found". "No bug found" implies that there will only ever be 0 or 1. "0 bug found" is just incorrect English.

[sylvestre.ledru]

OK. thanks. Sorry about the noise.
However, "1 bug found" is correct, right?

[jordan_rose]

Yes, that's correct. Thanks, Sylvestre!

[sylvestre.ledru]

Merged in commit r208951

tools/scan-build/scan-build

873

When it is 0, I think we have already left the function

tools/scan-build/scan-build

   die "No directory specified." if (!defined $Dir);
 
   if (! -d $Dir) {
-    Diag("No bugs found.\n");
+    Diag("No bug found.\n");
     return 0;
   }
 

       Diag("Removing directory '$Dir' because it contains no reports.\n");
       rmtree($Dir) or die "Cannot rmtree '$Dir' : $!";
     }
-    Diag("No bugs found.\n");
+    Diag("No bug found.\n");
     return 0;
   }
 

   print CalcStats(\@Stats) if $AnalyzerStats;
 
   my $Num = scalar(@Index);
-  Diag("$Num bugs found.\n");
+  if ($Num == 1) {
+    Diag("$Num bug found.\n");
+  } else {
+    Diag("$Num bugs found.\n");
+  }
   if ($Num > 0 && -r "$Dir/index.html") {
     Diag("Run 'scan-view $Dir' to examine bug reports.\n");
   }