Replace system() by native perl calls

[sylvestre.ledru]

Can I commit that?

[jordan_rose]

Looks fine. Thanks!

[sylvestre.ledru]

commit as r209524

tools/scan-build/ccc-analyzer

 if (!defined $ReportFailures) { $ReportFailures = 1; }
 
 my $CleanupFile;
 my $ResultFile;
 
 # Remove any stale files at exit.
 END {
   if (defined $ResultFile && -z $ResultFile) {
-    `rm -f $ResultFile`;
+    unlink($ResultFile);
   }
   if (defined $CleanupFile) {
-    `rm -f $CleanupFile`;
+    unlink($CleanupFile);
   }
 }
 
 ##----------------------------------------------------------------------------##
 #  Process Clang Crashes.
 ##----------------------------------------------------------------------------##
 
 sub GetPPExt {
sub ProcessClangFailure {
   # Create the info file.
   open (OUT, ">", "$PPFile.info.txt") or die "Cannot open $PPFile.info.txt\n";
   print OUT abs_path($file), "\n";
   print OUT "$ErrorType\n";
   print OUT "@$Args\n";
   close OUT;
   `uname -a >> $PPFile.info.txt 2>&1`;
   `$Compiler -v >> $PPFile.info.txt 2>&1`;
-  system 'mv',$ofile,"$PPFile.stderr.txt";
+  rename($ofile, "$PPFile.stderr.txt");
   return (basename $PPFile);
 }
 
 ##----------------------------------------------------------------------------##
 #  Running the analyzer.
 ##----------------------------------------------------------------------------##
 
 sub GetCCArgs {

tools/scan-build/scan-build

 ##===----------------------------------------------------------------------===##
 
 use strict;
 use warnings;
 use FindBin qw($RealBin);
 use Digest::MD5;
 use File::Basename;
 use File::Find;
+use File::Copy qw(copy);
+use File::Path qw( rmtree mkpath );
 use Term::ANSIColor;
 use Term::ANSIColor qw(:constants);
 use Cwd qw/ getcwd abs_path /;
 use Sys::Hostname;
 
 my $Verbose = 0;       # Verbose output from this script.
 my $Prog = "scan-build";
 my $BuildName;
sub GetHTMLRunDir {
   # Append the run number.
   my $NewDir;
   if ($TmpMode) {
     $NewDir = "$Dir/$Prog-$DateString-$RunNumber";
   }
   else {
     $NewDir = "$Dir/$DateString-$RunNumber";
   }
-  system 'mkdir','-p',$NewDir;
+  mkpath($NewDir);
   return $NewDir;
 }
 
 sub SetHtmlEnv {
 
   die "Wrong number of arguments." if (scalar(@_) != 2);
 
   my $Args = shift;
sub UpdateInFilePath {
 
   while (<RIN>) {
     s/$regex/$newtext/;
     print ROUT $_;
   }
 
   close (ROUT);
   close (RIN);
-  system("mv", "$fname.tmp", $fname);
+  rename("$fname.tmp", $fname)
 }
 
 ##----------------------------------------------------------------------------##
 # AddStatLine - Decode and insert a statistics line into the database.
 ##----------------------------------------------------------------------------##
 
 sub AddStatLine {
   my $Line  = shift;
sub ScanFile {
 
   # Compute a digest for the report file.  Determine if we have already
   # scanned a file that looks just like it.
 
   my $digest = ComputeDigest("$Dir/$FName");
 
   if (defined $AlreadyScanned{$digest}) {
     # Redundant file.  Remove it.
-    system ("rm", "-f", "$Dir/$FName");
+    unlink("$Dir/$FName");
     return;
   }
 
   $AlreadyScanned{$digest} = 1;
 
   # At this point the report file is not world readable.  Make it happen.
-  system ("chmod", "644", "$Dir/$FName");
+  chmod(0644, "$Dir/$FName");
 
   # Scan the report file for tags.
   open(IN, "$Dir/$FName") or DieDiag("Cannot open '$Dir/$FName'\n");
 
   my $BugType        = "";
   my $BugFile        = "";
   my $BugCategory    = "";
   my $BugDescription = "";
sub CopyFiles {
 
   my $Dir = shift;
 
   my $JS = Cwd::realpath("$RealBin/sorttable.js");
 
   DieDiag("Cannot find 'sorttable.js'.\n")
     if (! -r $JS);
 
-  system ("cp", $JS, "$Dir");
+  copy($JS, "$Dir");
 
   DieDiag("Could not copy 'sorttable.js' to '$Dir'.\n")
     if (! -r "$Dir/sorttable.js");
 
   my $CSS = Cwd::realpath("$RealBin/scanview.css");
 
   DieDiag("Cannot find 'scanview.css'.\n")
     if (! -r $CSS);
 
-  system ("cp", $CSS, "$Dir");
+  copy($CSS, "$Dir");
 
   DieDiag("Could not copy 'scanview.css' to '$Dir'.\n")
     if (! -r $CSS);
 }
 
 ##----------------------------------------------------------------------------##
 # CalcStats - Calculates visitation statistics and returns the string.
 ##----------------------------------------------------------------------------##
sub Postprocess {
   }
 
   $baseDir = $Dir . "/";
   find({ wanted => \&FileWanted, follow => 0}, $Dir);
 
   if (scalar(@filesFound) == 0 and ! -e "$Dir/failures") {
     if (! $KeepEmpty) {
       Diag("Removing directory '$Dir' because it contains no reports.\n");
-      system ("rm", "-fR", $Dir);
+      rmtree($Dir) or die "Cannot rmtree '$Dir' : $!";
     }
     Diag("No bugs found.\n");
     return 0;
   }
 
   # Scan each report file and build an index.
   my @Index;
   my @Stats;
if (scalar (@failures) || scalar(@attributes_ignored)) {
     print OUT "<p>Please consider submitting preprocessed files as <a href=\"http://clang-analyzer.llvm.org/filing_bugs.html\">bug reports</a>. <!-- REPORTCRASHES --> </p>\n";
   }
 
   print OUT "</body></html>\n";
   close(OUT);
   CopyFiles($Dir);
 
   # Make sure $Dir and $BaseDir are world readable/executable.
-  system("chmod", "755", $Dir);
-  if (defined $BaseDir) { system("chmod", "755", $BaseDir); }
+  chmod(0755, $Dir);
+  if (defined $BaseDir) { chmod(0755, $BaseDir); }
 
   # Print statistics
   print CalcStats(\@Stats) if $AnalyzerStats;
 
   my $Num = scalar(@Index);
   Diag("$Num bugs found.\n");
   if ($Num > 0 && -r "$Dir/index.html") {
     Diag("Run 'scan-view $Dir' to examine bug reports.\n");