This is an archive of the discontinued LLVM Phabricator instance.

Add '\n' in ClangDataCollectorsEmitter
ClosedPublic

Authored by kzhuravl on Sep 7 2017, 3:41 PM.

Download Raw Diff

Details

Reviewers

johannes
arphaman

Commits

rG500c25e5da14: Add '\n' in ClangDataCollectorsEmitter
rC312795: Add '\n' in ClangDataCollectorsEmitter
rL312795: Add '\n' in ClangDataCollectorsEmitter

Summary

Otherwise it breaks our internal windows builders:

StmtDataCollectors.inc: error C2220: warning treated as error - no 'object' file generated
StmtDataCollectors.inc: warning C4335: Mac file format detected: please convert the source file to either DOS or UNIX format

Diff Detail

Repository: rL LLVM

Event Timeline

kzhuravl created this revision.Sep 7 2017, 3:41 PM

Herald added subscribers: ilya-biryukov, wdng. · View Herald TranscriptSep 7 2017, 3:41 PM

LGTM. Do you have commit access?

This revision is now accepted and ready to land.Sep 7 2017, 10:48 PM

Closed by commit rL312795: Add '\n' in ClangDataCollectorsEmitter (authored by kzhuravl). · Explain WhySep 8 2017, 9:19 AM

This revision was automatically updated to reflect the committed changes.

In D37599#864376, @arphaman wrote:

LGTM. Do you have commit access?

Yep, committed. Thanks.

Revision Contents

Path

Size

cfe/

trunk/

utils/

TableGen/

ClangDataCollectorsEmitter.cpp

2 lines

Diff 114376

cfe/trunk/utils/TableGen/ClangDataCollectorsEmitter.cpp

	#include "llvm/TableGen/Record.h"			#include "llvm/TableGen/Record.h"
	#include "llvm/TableGen/TableGenBackend.h"			#include "llvm/TableGen/TableGenBackend.h"

	using namespace llvm;			using namespace llvm;

	namespace clang {			namespace clang {
	void EmitClangDataCollectors(RecordKeeper &RK, raw_ostream &OS) {			void EmitClangDataCollectors(RecordKeeper &RK, raw_ostream &OS) {
	const auto &Defs = RK.getClasses();			const auto &Defs = RK.getClasses();
	for (const auto &Entry : Defs) {			for (const auto &Entry : Defs) {
	Record &R = *Entry.second;			Record &R = *Entry.second;
	OS << "DEF_ADD_DATA(" << R.getName() << ", {";			OS << "DEF_ADD_DATA(" << R.getName() << ", {\n";
	auto Code = R.getValue("Code")->getValue();			auto Code = R.getValue("Code")->getValue();
	OS << Code->getAsUnquotedString() << "}\n)";			OS << Code->getAsUnquotedString() << "}\n)";
	OS << "\n";			OS << "\n";
	}			}
	OS << "#undef DEF_ADD_DATA\n";			OS << "#undef DEF_ADD_DATA\n";
	}			}
	} // end namespace clang			} // end namespace clang