This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Add device overloads for non-placement new/delete.
ClosedPublic

Authored by jlebar on Sep 6 2017, 4:06 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jlebar created this revision.Sep 6 2017, 4:06 PM
tra accepted this revision.Sep 6 2017, 5:20 PM
tra added inline comments.
clang/lib/Headers/cuda_wrappers/new
79 ↗(On Diff #114092)

Is std::size_t intentional here? You use SIZE_TYPE everywhere else.

This revision is now accepted and ready to land.Sep 6 2017, 5:20 PM
jlebar marked an inline comment as done.Sep 6 2017, 5:29 PM
jlebar added inline comments.
clang/lib/Headers/cuda_wrappers/new
79 ↗(On Diff #114092)

Fixed, thanks.

jlebar updated this revision to Diff 114104.Sep 6 2017, 5:29 PM
jlebar marked an inline comment as done.

Address review comments.

This revision was automatically updated to reflect the committed changes.