This is an archive of the discontinued LLVM Phabricator instance.

Differential D3751

[ubsan] fix vptr test on ARM
ClosedPublic

Authored by garious on May 13 2014, 7:12 PM.

Details

Reviewers
samsonov
rsmith
Commits
rG38ff5677439d: [ubsan] fix vptr test on ARM
rCRT209249: [ubsan] fix vptr test on ARM
rL209249: [ubsan] fix vptr test on ARM
Summary

Fixed vptr test. With this patch, all ubsan tests pass on qemu-arm.

Diff Detail

Event Timeline

garious updated this revision to Diff 9370.May 13 2014, 7:12 PM
garious retitled this revision from to [ubsan] fix vptr test on ARM.
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added reviewers: rsmith, samsonov.
garious added a subscriber: Unknown Object (MLST).
Herald added a subscriber: aemerson. · View Herald TranscriptMay 13 2014, 7:12 PM
garious updated this revision to Diff 9371.May 13 2014, 7:20 PM
rsmith edited edge metadata.May 13 2014, 7:37 PM

I see, the problem is that we're accidentally relying on the stack buffer 'Buffer' being 8-byte aligned.

test/ubsan/TestCases/TypeCheck/vptr.cpp
89

Please add an optional extra space between the two groups of 0s rather than making the second group optional.

You don't need the parens around the optional spaces.

garious updated this revision to Diff 9452.May 15 2014, 12:44 PM
garious edited edge metadata.

cleanup per Richard's feedback

garious added a comment.May 16 2014, 10:20 AM

Ping

garious closed this revision.May 20 2014, 3:15 PM
garious updated this revision to Diff 9643.

Closed by commit rL209249 (authored by @garious).

Revision Contents

PathSize
test/
ubsan/
TestCases/
TypeCheck/
2 lines

Diff 9452

test/ubsan/TestCases/TypeCheck/vptr.cpp

Context not available.
// CHECK-NULL-MEMBER: vptr.cpp:[[@LINE-2]]:15: runtime error: member access within address [[PTR:0x[0-9a-f]*]] which does not point to an object of type 'T' // CHECK-NULL-MEMBER: vptr.cpp:[[@LINE-2]]:15: runtime error: member access within address [[PTR:0x[0-9a-f]*]] which does not point to an object of type 'T'
// CHECK-NULL-MEMBER-NEXT: [[PTR]]: note: object has invalid vptr // CHECK-NULL-MEMBER-NEXT: [[PTR]]: note: object has invalid vptr
// CHECK-NULL-MEMBER-NEXT: {{^ .. .. .. .. 00 00 00 00 00 00 00 00 }} // CHECK-NULL-MEMBER-NEXT: {{^ ?.. .. .. .. ?00 00 00 00 ?00 00 00 00 ?}}
rsmithUnsubmitted
Not Done
ReplyInline Actions

Please add an optional extra space between the two groups of 0s rather than making the second group optional.

You don't need the parens around the optional spaces.

rsmith: Please add an optional extra space between the two groups of 0s rather than making the second…
// CHECK-NULL-MEMBER-NEXT: {{^ \^~~~~~~~~~~(~~~~~~~~~~~~)? *$}} // CHECK-NULL-MEMBER-NEXT: {{^ \^~~~~~~~~~~(~~~~~~~~~~~~)? *$}}
// CHECK-NULL-MEMBER-NEXT: {{^ invalid vptr}} // CHECK-NULL-MEMBER-NEXT: {{^ invalid vptr}}
Context not available.