[CMake][runtimes] Use the same configuration for non-target and "default" target

[phosek]

Summary

The default host target for builtins and runtimes has special behavior
on some platforms, e.g. on Linux both i386 and x86_64 targets are being
built. Specifying "default" as a target name should lead to the same
behavior, which wasn't the case in the past. This patch unifies the
configuration between the non-target and "default" target to produce the
same behavior by moving the default configuration into a function that
can be used from both paths.

[phosek]

ping

[beanz]

LGTM!

runtimes/CMakeLists.txt

 
 else() # if this is included from LLVM's CMake
   include(LLVMExternalProjectUtils)
 
   if(NOT LLVM_BUILD_RUNTIMES)
     set(EXTRA_ARGS EXCLUDE_FROM_ALL)
   endif()
 
-  # If compiler-rt is present we need to build the builtin libraries first. This
-  # is required because the other runtimes need the builtin libraries present
-  # before the just-built compiler can pass the configuration tests.
-  if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/compiler-rt)
-    if(NOT LLVM_BUILTIN_TARGETS)
-      llvm_ExternalProject_Add(builtins
-                               ${CMAKE_CURRENT_SOURCE_DIR}/compiler-rt/lib/builtins
-                               CMAKE_ARGS -DLLVM_LIBRARY_OUTPUT_INTDIR=${LLVM_LIBRARY_DIR}
-                                          -DLLVM_RUNTIME_OUTPUT_INTDIR=${LLVM_TOOLS_BINARY_DIR}
-                                          -DCMAKE_C_COMPILER_TARGET=${TARGET_TRIPLE}
-                                          -DCMAKE_ASM_COMPILER_TARGET=${TARGET_TRIPLE}
-                               PASSTHROUGH_PREFIXES COMPILER_RT
-                               USE_TOOLCHAIN
-                               ${EXTRA_ARGS})
-    else()
-      get_cmake_property(variableNames VARIABLES)
-      add_custom_target(builtins)
-      add_custom_target(install-builtins)
-      foreach(target ${LLVM_BUILTIN_TARGETS})
-        if(target STREQUAL "default")
-          set(target ${LLVM_DEFAULT_TARGET_TRIPLE})
-        endif()
+  function(builtin_default_target)
+  endfunction()
 
-        string(REPLACE "-" ";" builtin_target_list ${target})
-        foreach(item ${builtin_target_list})
-          string(TOLOWER "${item}" item_lower)
-          if(item_lower MATCHES "darwin")
-            message(FATAL_ERROR "LLVM_BUILTIN_TARGETS isn't implemented for Darwin platform!")
-          endif()
-        endforeach()
+  function(builtin_register_target target)
 
-        foreach(variableName ${variableNames})
-          if(variableName MATCHES "^BUILTINS_${target}")
-            string(REPLACE "BUILTINS_${target}_" "" new_name ${variableName})
-            list(APPEND ${target}_extra_args "-D${new_name}=${${variableName}}")
-          endif()
-        endforeach()
-        llvm_ExternalProject_Add(builtins-${target}
-                               ${CMAKE_CURRENT_SOURCE_DIR}/compiler-rt/lib/builtins
-                               CMAKE_ARGS -DLLVM_LIBRARY_OUTPUT_INTDIR=${LLVM_LIBRARY_DIR}
-                                          -DLLVM_RUNTIME_OUTPUT_INTDIR=${LLVM_TOOLS_BINARY_DIR}
-                                          -DCMAKE_C_COMPILER_TARGET=${target}
-                                          -DCMAKE_ASM_COMPILER_TARGET=${target}
-                                          -DCMAKE_C_COMPILER_WORKS=On
-                                          -DCMAKE_ASM_COMPILER_WORKS=On
-                                          -DCOMPILER_RT_DEFAULT_TARGET_ONLY=On
-                                          ${${target}_extra_args}
-                               TOOLCHAIN_TOOLS clang lld llvm-ar llvm-ranlib
-                               PASSTHROUGH_PREFIXES COMPILER_RT
-                               USE_TOOLCHAIN
-                               ${EXTRA_ARGS})
+    get_cmake_property(variableNames VARIABLES)
+
+  endfunction()
+
+  # If compiler-rt is present we need to build the builtin libraries first. This
+  # is required because the other runtimes need the builtin libraries present
+  # before the just-built compiler can pass the configuration tests.
+  if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/compiler-rt)
+    if(NOT LLVM_BUILTIN_TARGETS)
+      builtin_default_target()
+    else()
+      if("default" IN_LIST LLVM_BUILTIN_TARGETS)
+        builtin_default_target()
+        list(REMOVE_ITEM LLVM_BUILTIN_TARGETS "default")
+      else()
+        add_custom_target(builtins)
+        add_custom_target(install-builtins)
+      endif()
+
+      foreach(target ${LLVM_BUILTIN_TARGETS})
+        builtin_register_target(${target})
+
         add_dependencies(builtins builtins-${target})
         add_dependencies(install-builtins install-builtins-${target})
       endforeach()
     endif()
     set(deps builtins)
     # We don't need to depend on the builtins if we're building instrumented
     # because the next stage will use the same compiler used to build this stage.
     if(NOT LLVM_BUILD_INSTRUMENTED AND CLANG_ENABLE_BOOTSTRAP)
foreach(entry ${runtimes})
 
     string(FIND ${projName} "lib" LIB_IDX)
     if(LIB_IDX EQUAL 0)
       string(SUBSTRING ${projName} 3 -1 projName)
     endif()
     list(APPEND runtime_names ${projName})
   endforeach()
 
-  # runtime_register_target(target)
-  #   Utility function to register external runtime target.
-  function(runtime_register_target name target)
-    if(name STREQUAL LLVM_DEFAULT_TARGET_TRIPLE)
-      include(${LLVM_BINARY_DIR}/runtimes/Components.cmake OPTIONAL)
-      set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${LLVM_BINARY_DIR}/runtimes/Components.cmake)
-    else()
-      include(${LLVM_BINARY_DIR}/runtimes/${name}/Components.cmake OPTIONAL)
-      set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${LLVM_BINARY_DIR}/runtimes/${name}/Components.cmake)
-    endif()
+  function(runtime_default_target deps prefixes)
+
+    foreach(runtime_name ${runtime_names})
+      list(APPEND extra_targets
+        ${runtime_name}
+        install-${runtime_name})
+      if(LLVM_INCLUDE_TESTS)
+        list(APPEND test_targets check-${runtime_name})
+      endif()
+    endforeach()
+
+    if(LLVM_INCLUDE_TESTS)
+      list(APPEND test_targets runtimes-test-depends check-runtimes)
+    endif()
+
+    llvm_ExternalProject_Add(runtimes
+                             ${CMAKE_CURRENT_SOURCE_DIR}
+                             DEPENDS ${deps}
+                             # Builtins were built separately above
+                             CMAKE_ARGS -DCOMPILER_RT_BUILD_BUILTINS=Off
+                                        -DLLVM_INCLUDE_TESTS=${LLVM_INCLUDE_TESTS}
+                                        -DLLVM_LIBRARY_DIR=${LLVM_LIBRARY_DIR}
+                             PASSTHROUGH_PREFIXES ${prefixes}
+                             EXTRA_TARGETS ${extra_targets}
+                                           ${test_targets}
+                                           ${SUB_COMPONENTS}
+                                           ${SUB_CHECK_TARGETS}
+                                           ${SUB_INSTALL_TARGETS}
+                             USE_TOOLCHAIN
+                             ${EXTRA_ARGS})
+  endfunction()
+
+  # runtime_register_target(target)
+  #   Utility function to register external runtime target.
+  function(runtime_register_target name target deps prefixes)
 
     set(${name}_deps ${deps})
     if(NOT name STREQUAL target)
       list(APPEND ${name}_deps runtimes-${target})
     endif()
 
     foreach(runtime_name ${runtime_names})
       list(APPEND ${name}_extra_targets
foreach(variableName ${variableNames})
         string(REPLACE "RUNTIMES_${name}_" "" new_name ${variableName})
         list(APPEND ${name}_extra_args "-D${new_name}=${${variableName}}")
       elseif(variableName MATCHES "^RUNTIMES_${target}")
         string(REPLACE "RUNTIMES_${target}_" "" new_name ${variableName})
         list(APPEND ${name}_extra_args "-D${new_name}=${${variableName}}")
       endif()
     endforeach()
 
-    if(NOT target STREQUAL LLVM_DEFAULT_TARGET_TRIPLE)
-      list(APPEND ${name}_extra_args "-DLLVM_RUNTIMES_TARGET=${name}")
-    endif()
-
     llvm_ExternalProject_Add(runtimes-${name}
                              ${CMAKE_CURRENT_SOURCE_DIR}
                              DEPENDS ${${name}_deps}
                              # Builtins were built separately above
                              CMAKE_ARGS -DCOMPILER_RT_BUILD_BUILTINS=Off
                                         -DLLVM_INCLUDE_TESTS=${LLVM_INCLUDE_TESTS}
                                         -DLLVM_LIBRARY_DIR=${LLVM_LIBRARY_DIR}
                                         -DCMAKE_C_COMPILER_TARGET=${target}
                                         -DCMAKE_CXX_COMPILER_TARGET=${target}
                                         -DCMAKE_ASM_COMPILER_TARGET=${target}
                                         -DCMAKE_C_COMPILER_WORKS=ON
                                         -DCMAKE_CXX_COMPILER_WORKS=ON
                                         -DCMAKE_ASM_COMPILER_WORKS=ON
                                         -DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON
+                                        -DLLVM_RUNTIMES_TARGET=${name}
                                         ${${name}_extra_args}
                              TOOLCHAIN_TOOLS clang lld llvm-ar llvm-ranlib
                              PASSTHROUGH_PREFIXES ${prefixes}
                              EXTRA_TARGETS ${${name}_extra_targets}
                                            ${${name}_test_targets}
                              USE_TOOLCHAIN
                              ${EXTRA_ARGS})
   endfunction()
 
   if(runtimes)
     # Create a runtimes target that uses this file as its top-level CMake file.
     # The runtimes target is a configuration of all the runtime libraries
     # together in a single CMake invocaiton.
     if(NOT LLVM_RUNTIME_TARGETS)
-      include(${LLVM_BINARY_DIR}/runtimes/Components.cmake OPTIONAL)
-      set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${LLVM_BINARY_DIR}/runtimes/Components.cmake)
-
-      foreach(runtime_name ${runtime_names})
-        list(APPEND extra_targets
-          ${runtime_name}
-          install-${runtime_name})
-        if(LLVM_INCLUDE_TESTS)
-          list(APPEND test_targets check-${runtime_name})
-        endif()
-      endforeach()
-
-      if(LLVM_INCLUDE_TESTS)
-        list(APPEND test_targets runtimes-test-depends check-runtimes)
-      endif()
-
-      llvm_ExternalProject_Add(runtimes
-                               ${CMAKE_CURRENT_SOURCE_DIR}
-                               DEPENDS ${deps}
-                               # Builtins were built separately above
-                               CMAKE_ARGS -DCOMPILER_RT_BUILD_BUILTINS=Off
-                                          -DLLVM_INCLUDE_TESTS=${LLVM_INCLUDE_TESTS}
-                                          -DLLVM_LIBRARY_DIR=${LLVM_LIBRARY_DIR}
-                               PASSTHROUGH_PREFIXES ${prefixes}
-                               EXTRA_TARGETS ${extra_targets}
-                                              ${test_targets}
-                                              ${SUB_COMPONENTS}
-                                              ${SUB_CHECK_TARGETS}
-                                              ${SUB_INSTALL_TARGETS}
-                               USE_TOOLCHAIN
-                               ${EXTRA_ARGS})
+      runtime_default_target(${deps} ${prefixes})
+    else()
+      if("default" IN_LIST LLVM_RUNTIME_TARGETS)
+        runtime_default_target(${deps} ${prefixes})
+        list(REMOVE_ITEM LLVM_RUNTIME_TARGETS "default")
       else()
         add_custom_target(runtimes)
         add_custom_target(runtimes-configure)
         add_custom_target(install-runtimes)
         if(LLVM_INCLUDE_TESTS)
           add_custom_target(check-runtimes)
           add_custom_target(runtimes-test-depends)
           set(test_targets "")
         endif()
-
-      foreach(name ${LLVM_RUNTIME_TARGETS})
-        if(name STREQUAL "default")
-          set(name ${LLVM_DEFAULT_TARGET_TRIPLE})
-        endif()
 
+      foreach(name ${LLVM_RUNTIME_TARGETS})
         set(target ${name})
         string(REPLACE ":" ";" target_list ${target})
         list(GET target_list 0 name)
         list(LENGTH target_list target_list_len)
         if(${target_list_len} GREATER 1)
           list(GET target_list 1 target)
         endif()
 
-        runtime_register_target(${name} ${target})
+        runtime_register_target(${name} ${target} ${deps} ${prefixes})
 
         add_dependencies(runtimes runtimes-${name})
         add_dependencies(runtimes-configure runtimes-${name}-configure)
         add_dependencies(install-runtimes install-runtimes-${name})
         if(LLVM_INCLUDE_TESTS)
           add_dependencies(check-runtimes check-runtimes-${name})
           add_dependencies(runtimes-test-depends runtimes-test-depends-${name})
         endif()