This is an archive of the discontinued LLVM Phabricator instance.

LowerTypeTests: Add import/export support for targets without absolute symbol constants.
ClosedPublic

Authored by pcc on Sep 1 2017, 5:29 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Sep 1 2017, 5:29 PM
eugenis accepted this revision.Sep 11 2017, 2:22 PM
eugenis added inline comments.
llvm/include/llvm/IR/ModuleSummaryIndex.h
497 ↗(On Diff #113628)

Add comments for these new fields.

llvm/lib/Transforms/IPO/LowerTypeTests.cpp
815 ↗(On Diff #113628)

Comment that IntTy==nullptr means we actually want Int8PtrTy.
Maybe change the function to accept Type*, and do ptrcast if it is a PointerType, and create a ConstantInt directly if it is an IntegerType?

This revision is now accepted and ready to land.Sep 11 2017, 2:22 PM
pcc marked an inline comment as done.Sep 11 2017, 3:50 PM
pcc added inline comments.
llvm/include/llvm/IR/ModuleSummaryIndex.h
497 ↗(On Diff #113628)

I added a reference to LowerTypeTests.cpp where their meanings are already documented.

This revision was automatically updated to reflect the committed changes.