This makes armv4 platform support easier.
Details
Diff Detail
Event Timeline
lib/builtins/arm/vfp/adddf3vfp.S | ||
---|---|---|
10 | Im tempted to say that we should adjust the CPPFLAGS to include $(top_srcdir)/lib/builtins in the include search path and make this into: #include "assembly.h" We certainly do similar things on the LLVM side where we assume that $(top_srcdir)/include is in the search path for headers. I don't think that the minor discomfort of gf no longer working in vim is a huge loss. |
lib/builtins/arm/vfp/adddf3vfp.S | ||
---|---|---|
10 | Yeah, I'm not a huge fan of '../' in include paths either, but I don't feel comfortable enough with compiler-rt's makefiles to make that change.... they're quite complicated :) |
The change looks good, though I agree we should change the include path, this is getting out of hand.
cheers,
--renato
Compnerd made an interesting point yesterday that maybe the new folder ought to be named 'softfp'. That way we aren't naming it off of an ISA feature, but rather an ABI. Thoughts?
Also, what are your thoughts on dropping the 'vfp' from the filenames in the move?
I agree softfp is a good idea. Also, to remove the vfp from the name.
cheers,
--renato
Im tempted to say that we should adjust the CPPFLAGS to include $(top_srcdir)/lib/builtins in the include search path and make this into:
We certainly do similar things on the LLVM side where we assume that $(top_srcdir)/include is in the search path for headers. I don't think that the minor discomfort of gf no longer working in vim is a huge loss.