This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Move arm vfp builtins to their own folder
AbandonedPublic

Authored by jroelofs on May 12 2014, 1:31 PM.

Details

Reviewers
compnerd
Summary

This makes armv4 platform support easier.

Diff Detail

Event Timeline

jroelofs updated this revision to Diff 9324.May 12 2014, 1:31 PM
jroelofs retitled this revision from to [compiler-rt] Move arm vfp builtins to their own folder.
jroelofs updated this object.
jroelofs edited the test plan for this revision. (Show Details)
jroelofs added a reviewer: compnerd.
jroelofs added subscribers: Unknown Object (MLST), Unknown Object (MLST).
jroelofs updated this revision to Diff 9326.May 12 2014, 2:29 PM

Forgot to svn add lib/builtins/arm/vfp/Makefile.mk before diffing.

compnerd added inline comments.May 12 2014, 5:29 PM
lib/builtins/arm/vfp/adddf3vfp.S
10

Im tempted to say that we should adjust the CPPFLAGS to include $(top_srcdir)/lib/builtins in the include search path and make this into:

#include "assembly.h"

We certainly do similar things on the LLVM side where we assume that $(top_srcdir)/include is in the search path for headers. I don't think that the minor discomfort of gf no longer working in vim is a huge loss.

jroelofs added inline comments.May 12 2014, 5:45 PM
lib/builtins/arm/vfp/adddf3vfp.S
10

Yeah, I'm not a huge fan of '../' in include paths either, but I don't feel comfortable enough with compiler-rt's makefiles to make that change.... they're quite complicated :)

The change looks good, though I agree we should change the include path, this is getting out of hand.

cheers,
--renato

Compnerd made an interesting point yesterday that maybe the new folder ought to be named 'softfp'. That way we aren't naming it off of an ISA feature, but rather an ABI. Thoughts?

Also, what are your thoughts on dropping the 'vfp' from the filenames in the move?

I agree softfp is a good idea. Also, to remove the vfp from the name.

cheers,
--renato

jroelofs abandoned this revision.Aug 27 2015, 8:27 AM
lib/builtins/arm/unorddf2vfp.S