Page MenuHomePhabricator

[codeview] Generalize DIExpression parsing to handle load chains
ClosedPublic

Authored by rnk on Aug 30 2017, 1:55 PM.

Details

Summary

Hopefully this also clarifies exactly when and why we're rewriting
certiain S_LOCALs using reference types: We're using the reference type
to stand in for a zero-offset load.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Aug 30 2017, 1:55 PM
inglorion accepted this revision.Aug 30 2017, 2:57 PM

lgtm modulo inline comment. Thanks!

llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
81 ↗(On Diff #113308)

Is this accidentally left in printstrumentation?

This revision is now accepted and ready to land.Aug 30 2017, 2:57 PM
This revision was automatically updated to reflect the committed changes.