This is an archive of the discontinued LLVM Phabricator instance.

Differential D37213

Changed Dockerfiles to install LLVM into /usr/local
ClosedPublic

Authored by ilya-biryukov on Aug 28 2017, 7:34 AM.

Details

Reviewers
mehdi_amini
klimek
Commits
rG867e36de383e: Changed Dockerfiles to install LLVM into /usr/local
rL311890: Changed Dockerfiles to install LLVM into /usr/local
Summary

Previously, the installation path was simply '/'.
Using '/usr/local' would ensure that LLVM installation does not
conflict with software installed via package managers.

Diff Detail

Event Timeline

ilya-biryukov created this revision.Aug 28 2017, 7:34 AM
Harbormaster completed remote builds in B9690: Diff 112897.Aug 28 2017, 7:35 AM
klimek accepted this revision.Aug 28 2017, 7:56 AM

LG - / was definitely wrong :)

This revision is now accepted and ready to land.Aug 28 2017, 7:56 AM
Closed by commit rL311890: Changed Dockerfiles to install LLVM into /usr/local (authored by ibiryukov). · Explain WhyAug 28 2017, 8:13 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini edited edge metadata.Aug 28 2017, 9:21 AM

I don't mind where you install it, but we can also assume that someone who use this Dockerfile intends to use clang, so why not adding it to to update-alternatives as well, and even making it default for /usr/bin/c++ and /usr/bin/cc?

Revision Contents

PathSize
utils/
docker/
debian8/
release/
2 lines
example/
release/
2 lines
nvidia-cuda/
release/
2 lines

Diff 112897

utils/docker/debian8/release/Dockerfile

Show All 12 Lines
LABEL maintainer "LLVM Developers" LABEL maintainer "LLVM Developers"
# Install packages for minimal useful image. # Install packages for minimal useful image.
RUN apt-get update && \ RUN apt-get update && \
apt-get install -y --no-install-recommends libstdc++-4.9-dev binutils && \ apt-get install -y --no-install-recommends libstdc++-4.9-dev binutils && \
rm -rf /var/lib/apt/lists/* rm -rf /var/lib/apt/lists/*
# Unpack clang installation into this image. # Unpack clang installation into this image.
ADD clang.tar.gz / ADD clang.tar.gz /usr/local/

utils/docker/example/release/Dockerfile

Show All 15 Lines
# FIXME: Change maintainer name. # FIXME: Change maintainer name.
LABEL maintainer "Maintainer <maintainer@email>" LABEL maintainer "Maintainer <maintainer@email>"
# FIXME: Install all packages you want to have in your release container. # FIXME: Install all packages you want to have in your release container.
# A minimal useful installation must include libstdc++ and binutils. # A minimal useful installation must include libstdc++ and binutils.
# Unpack clang installation into this container. # Unpack clang installation into this container.
# It is copied to this directory by build_docker_image.sh script. # It is copied to this directory by build_docker_image.sh script.
ADD clang.tar.gz / ADD clang.tar.gz /usr/local/

utils/docker/nvidia-cuda/release/Dockerfile

Show All 12 Lines
# FIXME: Replace 'ubuntu' with your base image. # FIXME: Replace 'ubuntu' with your base image.
FROM nvidia/cuda:8.0-devel FROM nvidia/cuda:8.0-devel
# FIXME: Change maintainer name. # FIXME: Change maintainer name.
LABEL maintainer "LLVM Developers" LABEL maintainer "LLVM Developers"
# Unpack clang installation into this container. # Unpack clang installation into this container.
ADD clang.tar.gz / ADD clang.tar.gz /usr/local/
# C++ standard library and binutils are already included in the base package. # C++ standard library and binutils are already included in the base package.