D36782 broke lld buildbots, because I've changed OptionInfo's type
from ArrayRef to std::vector, so it became a copy, not a reference.
In this patch, I changed Table to static, so that it won't be freed
after the return. However, I'm not sure if this is Ok for lld, because
it requires this function to be called atomic.
Details
Details
- Reviewers
ruiu v.g.vassilev teemperor
Diff Detail
Diff Detail
- Build Status
Buildable 9682 Build 9682: arc lint + arc unit
Event Timeline
Comment Actions
Technically, this patch fixes your issue, but I don't think this is a good way of fixing it because parse() function now has an internal state which is not obvious to the user of the function. Can you review https://reviews.llvm.org/D37217? This is an alternative fix that doesn't use a static local variables.