This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Correct operand types for v_mad_mix*
ClosedPublic

Authored by arsenm on Aug 24 2017, 3:36 PM.

Details

Reviewers
dp
Summary

These aren't really packed instructions, so the default
op_sel_hi should be 0 since this indicates a conversion.
The operand types are scalar values that behave similar
to an f16 scalar that may be converted to f32.

Doesn't change the default printing for op_sel_hi, just
the parsing.

Is there a script to update test/MC/AMDGPU/gfx9_asm_all.s? I got tired of manually updating all of the cases in it so it fails now.

Diff Detail

Event Timeline

arsenm created this revision.Aug 24 2017, 3:36 PM
dp accepted this revision.Aug 26 2017, 2:01 AM

Looks good, except for minor issues.

Regarding gfx9_asm_all.s: you should not update it, just delete all offending tests. The file will be updated by a test generator later.

lib/Target/AMDGPU/AMDGPU.td
718

unused

lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
4275

That would be nice. Maybe by a separate change?

This revision is now accepted and ready to land.Aug 26 2017, 2:01 AM
arsenm closed this revision.Aug 30 2017, 3:20 PM

r312179