Page MenuHomePhabricator

[clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check.
ClosedPublic

Authored by hokein on Aug 23 2017, 8:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

hokein created this revision.Aug 23 2017, 8:58 AM
alexfh added inline comments.Aug 23 2017, 9:20 AM
clang-tidy/modernize/MakeSmartPtrCheck.cpp
279 ↗(On Diff #112378)

I wonder whether this exception can be too broad, e.g. if the initializer list is a part of a more deeply nested expression inside the CXXConstructExpr?

hokein updated this revision to Diff 112519.Aug 24 2017, 1:55 AM
hokein marked an inline comment as done.

restrict to implicit conversion from std::initializer_list.

hokein added inline comments.Aug 24 2017, 2:00 AM
clang-tidy/modernize/MakeSmartPtrCheck.cpp
279 ↗(On Diff #112378)

Done. I overthought the cases here. The case we need to ignore is the implicit conversion from std::initailizer_list.

alexfh accepted this revision.Aug 24 2017, 5:44 AM

LG. Thanks!

This revision is now accepted and ready to land.Aug 24 2017, 5:44 AM
This revision was automatically updated to reflect the committed changes.