[ELF] - Do not allow --dynamic-list and --version-script together.

[grimar]

Summary

In PR34057 was mentioned that currently we have difference
in behavior with ld.bfd when these options are used together.
LLD implements --dynamic-list as simplified version script.
It is generally unclear why would someone want to use them together.
And also currently it complains (warns) about having a duplicate symbol f
in version script if f present both in dynamic list and version script, what
is not nice either.

It was suggested in comments to restrict such a combination,
and it seems reasonable solution to me.

[smeenai]

--dynamic-list and --version-script don't make sense together when building an executable, but the combination can be useful for a shared library. See D36499 for how the two should work together for a shared library.

[grimar]

In D37008#848762, @smeenai wrote:

--dynamic-list and --version-script don't make sense together when building an executable, but the combination can be useful for a shared library. See D36499 for how the two should work together for a shared library.

Ah, I missed that one, thanks for pointing. Abandoning this for now.

ELF/Driver.cpp

if (Config->Shared)
       error("-r and -shared may not be used together");
     if (Config->GcSections)
       error("-r and --gc-sections may not be used together");
     if (Config->ICF)
       error("-r and --icf may not be used together");
     if (Config->Pie)
       error("-r and -pie may not be used together");
   }
+
+  if (Args.hasArg(OPT_version_script) && Args.hasArg(OPT_dynamic_list))
+    error("--version-script and --dynamic-list may not be used together");
 }
 
 static int getInteger(opt::InputArgList &Args, unsigned Key, int Default) {
   int V = Default;
   if (auto *Arg = Args.getLastArg(Key)) {
     StringRef S = Arg->getValue();
     if (!to_integer(S, V, 10))
       error(Arg->getSpelling() + ": number expected, but got " + S);

test/ELF/version-script.s

 # ERR2: EOF expected, but got VERSION_2.0
 
 # RUN: echo "VERSION_1.0 { global: foo1; local: *; };" > %t6.script
 # RUN: echo "VERSION_2.0 { global: foo1; local: *; };" >> %t6.script
 # RUN: ld.lld --version-script %t6.script -shared %t.o %t2.so -o %t6.so 2>&1 | \
 # RUN:   FileCheck -check-prefix=WARN2 %s
 # WARN2: duplicate symbol 'foo1' in version script
 
+## --dynamic-list and --version-script may not be used together.
 # RUN: echo "{ foo1; foo2; };" > %t.list
-# RUN: ld.lld --version-script %t.script --dynamic-list %t.list %t.o %t2.so -o %t2
-# RUN: llvm-readobj %t2 > /dev/null
+# RUN: not ld.lld --version-script %t.script --dynamic-list %t.list %t.o \
+# RUN:   %t2.so -o %t2 2>&1 | FileCheck -check-prefix=ERR3 %s
+# ERR3: --version-script and --dynamic-list may not be used together
 
 # DSO:      DynamicSymbols [
 # DSO-NEXT:   Symbol {
 # DSO-NEXT:     Name: @
 # DSO-NEXT:     Value: 0x0
 # DSO-NEXT:     Size: 0
 # DSO-NEXT:     Binding: Local (0x0)
 # DSO-NEXT:     Type: None (0x0)