Remove code duplication from StringLiteral::setString method

[riccibruno]

Summary

Hi,

I'd like to submit a small patch that introduces a static generic string copy method. With that method that we can get rid of the code duplication in StringLiteral::setString.

What do you think?

Thanks,
Mateusz

[riccibruno]

The StringLiteral::setString interface has been removed in D54166 so I am closing this revision.

include/clang/AST/Expr.h

 
   static int mapCharByteWidth(TargetInfo const &target,StringKind k);
 
+  template <typename CharType>
+  static CharType *allocateAndCopyString(const ASTContext &C, StringRef Str,
+                                         unsigned Len) {
+    CharType *AStrData = new (C) CharType[Len];
+    std::memcpy(AStrData,Str.data(),Len*sizeof(CharType));
+    return AStrData;
+  }
+
 public:
   /// This is the "fully general" constructor that allows representation of
   /// strings formed from multiple concatenated tokens.

lib/AST/Expr.cpp

 
   switch(CharByteWidth) {
     case 1: {
-      char *AStrData = new (C) char[Length];
-      std::memcpy(AStrData,Str.data(),Length*sizeof(*AStrData));
-      StrData.asChar = AStrData;
+      StrData.asChar = allocateAndCopyString<char>(C, Str, Length);
       break;
     }
     case 2: {
-      uint16_t *AStrData = new (C) uint16_t[Length];
-      std::memcpy(AStrData,Str.data(),Length*sizeof(*AStrData));
-      StrData.asUInt16 = AStrData;
+      StrData.asUInt16 = allocateAndCopyString<uint16_t>(C, Str, Length);
       break;
     }
     case 4: {
-      uint32_t *AStrData = new (C) uint32_t[Length];
-      std::memcpy(AStrData,Str.data(),Length*sizeof(*AStrData));
-      StrData.asUInt32 = AStrData;
+      StrData.asUInt32 = allocateAndCopyString<uint32_t>(C, Str, Length);
       break;
     }
     default: