- User Since
- Jan 16 2017, 12:26 PM (284 w, 5 d)
Jun 2 2022
Thank you for such a detailed comment. Makes sense. I need to think how to proceed. Will ping you when I figure something out.
May 30 2022
I think clang-format is yelling at places where formatting should not be applied, so I'm gonna ignore that.
May 29 2022
Thank you for review! Implemented the changes
May 12 2022
Well, unfortunately I'm unable to reproduce the failed builds. Everything passes for me locally. @lattner or @klimek, or someone who you think is a good candidate to review this code - could you please try to test it?
Could you please assist me how to proceed with this patch?
Apr 21 2022
Sorry for the delay of fixing failed builds. Full builds and tests take some time. I'm working on it, promise.
The code itself won't change much, so I think it can be reviewed. Or at least the idea can be judged if it's something desired to have in clang. @lattner or @klimek could you please recommend someone to ask for review?
Apr 11 2022
Great, I can see some builds have failed. Will do my best to fix that tomorrow.
Jan 10 2019
Hi again, since I don't have commit rights, could you please merge this patch into the project sources? Thanks in advance.
Oct 11 2018
@rsmith Of course. Not sure what's better: to submit one patch per case or submit all of them in one patch (didn't deal much with them, not sure how big will the change be)?
Oct 4 2018
@Rakete1111 Any more comments?
Sep 18 2018
Friendly ping (:
Sep 11 2018
Not sure if you guys are still reviewing this. Do you have any more thoughts? If no, what should I do to move further with the patch?
Aug 31 2018
@Rakete1111 or anyone else, any more comments? (:
Aug 27 2018
Added missing semicolon.
Aug 26 2018
Added test cases for the code.
Aug 22 2018
Thanks for the advice. Should I update a new diff with -U99999?
@Rakete1111 Thank you for the comments. You're perfectly right, there was an issue in my code. I've fixed it and also E1 and E2 will be sequenced only in C++ >= 17.
Aug 15 2018
Thanks for pointing that out. You're probably right, these two calls are self-explanatory.
Aug 22 2017
Aug 19 2017
Jan 24 2017
@djasper You're probably right. Thanks anyway for your time (: