Page MenuHomePhabricator

stryku (Mateusz Janek)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 16 2017, 12:26 PM (284 w, 5 d)

Recent Activity

Jun 2 2022

stryku added a comment to D123532: [clang] Introduce while and do..while condition checks.

Thank you for such a detailed comment. Makes sense. I need to think how to proceed. Will ping you when I figure something out.

Jun 2 2022, 1:10 PM · Restricted Project, Restricted Project

May 30 2022

stryku added a comment to D123532: [clang] Introduce while and do..while condition checks.

I think clang-format is yelling at places where formatting should not be applied, so I'm gonna ignore that.

May 30 2022, 12:31 PM · Restricted Project, Restricted Project

May 29 2022

stryku updated the diff for D123532: [clang] Introduce while and do..while condition checks.

Thank you for review! Implemented the changes

May 29 2022, 10:08 AM · Restricted Project, Restricted Project

May 12 2022

stryku added a comment to D123532: [clang] Introduce while and do..while condition checks.

Well, unfortunately I'm unable to reproduce the failed builds. Everything passes for me locally. @lattner or @klimek, or someone who you think is a good candidate to review this code - could you please try to test it?
Could you please assist me how to proceed with this patch?

May 12 2022, 1:21 PM · Restricted Project, Restricted Project

Apr 21 2022

stryku added a comment to D123532: [clang] Introduce while and do..while condition checks.

Sorry for the delay of fixing failed builds. Full builds and tests take some time. I'm working on it, promise.
The code itself won't change much, so I think it can be reviewed. Or at least the idea can be judged if it's something desired to have in clang. @lattner or @klimek could you please recommend someone to ask for review?

Apr 21 2022, 3:12 PM · Restricted Project, Restricted Project

Apr 11 2022

stryku added a comment to D123532: [clang] Introduce while and do..while condition checks.

Great, I can see some builds have failed. Will do my best to fix that tomorrow.

Apr 11 2022, 1:47 PM · Restricted Project, Restricted Project
stryku retitled D123532: [clang] Introduce while and do..while condition checks from Introduce while and do..while condition checks to [clang] Introduce while and do..while condition checks.
Apr 11 2022, 11:45 AM · Restricted Project, Restricted Project
stryku requested review of D123532: [clang] Introduce while and do..while condition checks.
Apr 11 2022, 11:40 AM · Restricted Project, Restricted Project

Jan 10 2019

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Hi again, since I don't have commit rights, could you please merge this patch into the project sources? Thanks in advance.

Jan 10 2019, 7:42 AM · Restricted Project

Oct 11 2018

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

@rsmith Of course. Not sure what's better: to submit one patch per case or submit all of them in one patch (didn't deal much with them, not sure how big will the change be)?

Oct 11 2018, 12:43 PM · Restricted Project
stryku added inline comments to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..
Oct 11 2018, 12:38 PM · Restricted Project

Oct 4 2018

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

@Rakete1111 Any more comments?

Oct 4 2018, 2:59 AM · Restricted Project

Sep 18 2018

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Friendly ping (:

Sep 18 2018, 10:02 AM · Restricted Project

Sep 11 2018

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Not sure if you guys are still reviewing this. Do you have any more thoughts? If no, what should I do to move further with the patch?

Sep 11 2018, 12:00 PM · Restricted Project

Aug 31 2018

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

@Rakete1111 or anyone else, any more comments? (:

Aug 31 2018, 1:53 AM · Restricted Project

Aug 27 2018

stryku updated the diff for D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Added missing semicolon.

Aug 27 2018, 1:34 AM · Restricted Project

Aug 26 2018

stryku updated the diff for D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Added test cases for the code.

Aug 26 2018, 11:14 AM · Restricted Project

Aug 22 2018

stryku added a comment to D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Thanks for the advice. Should I update a new diff with -U99999?

Aug 22 2018, 7:27 AM · Restricted Project
stryku updated the diff for D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

@Rakete1111 Thank you for the comments. You're perfectly right, there was an issue in my code. I've fixed it and also E1 and E2 will be sequenced only in C++ >= 17.

Aug 22 2018, 6:47 AM · Restricted Project

Aug 15 2018

stryku updated the diff for D50766: Fix false positive unsequenced access and modification warning in array subscript expression..

Thanks for pointing that out. You're probably right, these two calls are self-explanatory.

Aug 15 2018, 12:18 PM · Restricted Project
stryku created D50766: Fix false positive unsequenced access and modification warning in array subscript expression..
Aug 15 2018, 4:59 AM · Restricted Project

Aug 22 2017

stryku retitled D36932: Remove code duplication from StringLiteral::setString method from [PATCH] Remove code duplication from StringLiteral::setString method to Remove code duplication from StringLiteral::setString method.
Aug 22 2017, 1:05 AM · Restricted Project, Restricted Project

Aug 19 2017

stryku added a reviewer for D36932: Remove code duplication from StringLiteral::setString method: rsmith.
Aug 19 2017, 3:38 PM · Restricted Project, Restricted Project
stryku created D36932: Remove code duplication from StringLiteral::setString method.
Aug 19 2017, 3:35 PM · Restricted Project, Restricted Project

Jan 24 2017

stryku added a comment to D29039: [clang-format] Proposal for clang-format -r option.

@djasper You're probably right. Thanks anyway for your time (:

Jan 24 2017, 9:07 AM · Restricted Project, Restricted Project, Restricted Project

Jan 23 2017

stryku created D29039: [clang-format] Proposal for clang-format -r option.
Jan 23 2017, 9:50 AM · Restricted Project, Restricted Project, Restricted Project