This is an archive of the discontinued LLVM Phabricator instance.

[llvm-dlltool] Improve an error message when unable to open files. NFC.
ClosedPublic

Authored by mstorsjo on Aug 16 2017, 11:04 PM.

Reviewers

ruiu
martell

Commits

LGTM

This revision is now accepted and ready to land.Aug 16 2017, 11:07 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

ToolDrivers/

llvm-dlltool/

2 lines

	Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines
	std::vector<std::unique_ptr<MemoryBuffer>> OwningMBs;			std::vector<std::unique_ptr<MemoryBuffer>> OwningMBs;

	// Opens a file. Path has to be resolved already.			// Opens a file. Path has to be resolved already.
	// Newly created memory buffers are owned by this driver.			// Newly created memory buffers are owned by this driver.
	Optional<MemoryBufferRef> openFile(StringRef Path) {			Optional<MemoryBufferRef> openFile(StringRef Path) {
	ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> MB = MemoryBuffer::getFile(Path);			ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> MB = MemoryBuffer::getFile(Path);

	if (std::error_code EC = MB.getError()) {			if (std::error_code EC = MB.getError()) {
	llvm::errs() << "fail openFile: " << EC.message() << "\n";			llvm::errs() << "cannot open file " << Path << ": " << EC.message() << "\n";
	return None;			return None;
	}			}

	MemoryBufferRef MBRef = MB.get()->getMemBufferRef();			MemoryBufferRef MBRef = MB.get()->getMemBufferRef();
	OwningMBs.push_back(std::move(MB.get())); // take ownership			OwningMBs.push_back(std::move(MB.get())); // take ownership
	return MBRef;			return MBRef;
	}			}

	▲ Show 20 Lines • Show All 109 Lines • Show Last 20 Lines