Page MenuHomePhabricator

[InstCombine] Teach canEvaluateZExtd and canEvaluateTruncated to handle vector shifts with splat shift amount
ClosedPublic

Authored by craig.topper on Aug 15 2017, 11:49 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

spatel edited edge metadata.Aug 15 2017, 3:29 PM

Can you commit this one first with at least one test independent of those in D36498 to avoid the extra inst regressions seen there?

Sure I'll flip the dependency and use the cast.ll test cases from here only. Do you need me to upload the altered patch to this or can you approve as is?

spatel accepted this revision.Aug 15 2017, 3:37 PM

LGTM with change of the test diffs so this one goes in first.

This revision is now accepted and ready to land.Aug 15 2017, 3:37 PM
spatel added inline comments.Aug 15 2017, 3:38 PM
lib/Transforms/InstCombine/InstCombineCasts.cpp
360 ↗(On Diff #111224)

I think you want to brace this case same as the rest.

This revision was automatically updated to reflect the committed changes.