This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Adding miniFE Benchmark
ClosedPublic

Authored by homerdin on Aug 14 2017, 8:42 AM.

Details

Summary
Description:

MiniFE is an proxy application for unstructured implicit finite element codes. It is similar to HPCCG and pHPCCG but provides a much more complete vertical covering of the steps in this class of applications. MiniFE also provides support for computation on multicore nodes, including pthreads and Intel Threading Building Blocks (TBB) for homogeneous multicore and CUDA for GPUs.

This is a serial build for the test-suite.

Links:

Web: https://mantevo.org/packages/
Github: https://github.com/Mantevo/miniFE

When run on Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz:
compile_time: 65.8697 
exec_time: 3.3827 
Maximum resident set size (kbytes): 401472

Diff Detail

Event Timeline

homerdin created this revision.Aug 14 2017, 8:42 AM
MatzeB requested changes to this revision.Aug 15 2017, 2:43 PM
  • I'd like to hear more comments on the license (see below).
  • Integration looks good to me
  • Maybe put the benchmark descriptions in a README file into the benchmark directory
MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/Box.hpp
8–9

This sentence feels odd and I wonder how this would be compatible with the LGPL statements following it.

Can you clarify this or drop them?

This revision now requires changes to proceed.Aug 15 2017, 2:43 PM
hfinkel added inline comments.
MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/Box.hpp
8–9

Software released by US government contractors often has these statements (or at least used to). I believe that, technically, the statement is a nop to anyone not acting on behalf of the US government, and only applies to the code as originally released.

@dberlin , thoughts on this?

homerdin updated this revision to Diff 111392.Aug 16 2017, 11:57 AM
homerdin edited edge metadata.

I created a README file for the description.

dberlin edited edge metadata.Aug 17 2017, 10:06 PM

The statements are, AFAIK, best viewed as statements of provenance, and are fairly normal for government released works (some are even required by statute)
They do not change or affect the license in any way.

They might as well say "this was written by Jim, for Bob"

MatzeB accepted this revision.Aug 18 2017, 10:48 AM

LGTM (nitpicks below).

LICENSE.TXT
87

indentation seems off

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/CMakeLists.txt
2

should work as well without quoting the flags.

This revision is now accepted and ready to land.Aug 18 2017, 10:48 AM
homerdin updated this revision to Diff 111723.Aug 18 2017, 12:41 PM

Thanks for the review. I corrected the LICENSE.TXT formatting and removed the unneeded quotes.

Brian

Thanks for the review. I corrected the LICENSE.TXT formatting and removed the unneeded quotes.

Brian

I already accepted this last time, so you could have just fixed the nitpicks and commit without reuploading for review. In any way still LGTM.

This revision was automatically updated to reflect the committed changes.