This is an archive of the discontinued LLVM Phabricator instance.

[lld] [COFF] Don't produce weak aliases in import libraries
ClosedPublic

Authored by mstorsjo on Aug 11 2017, 1:01 PM.

Details

Summary

When creating an import library from lld, the cases with Name != ExtName shouldn't end up as a weak alias, but as a real export of the new name, which is what actually is exported from the DLL.

This restores the behaviour of renamed exports to what it was in 4.0 - this is a regression since the introduction of llvm-dlltool.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Aug 11 2017, 1:01 PM
rnk accepted this revision.Aug 14 2017, 2:03 PM

lgtm

This revision is now accepted and ready to land.Aug 14 2017, 2:03 PM

Just FWIW, I was about to commit this, but noticed that this test actually depends on D36545, which depends on D36544 (which is yet unapproved). So I'll need to hold off of this one until those patches are merged first.

This revision was automatically updated to reflect the committed changes.