Page MenuHomePhabricator
Differential D36546

Garbage-collect common symbols.
ClosedPublic
Actions

Authored by ruiu on Aug 9 2017, 1:16 PM.

Details

Reviewers
grimar
Commits
rG9c77d27004a1: Garbage-collect common symbols.
rLLD310617: Garbage-collect common symbols.
rL310617: Garbage-collect common symbols.
Summary

Liveness is usually a notion of input sections, but this patch adds
"liveness" bit to common symbols because they don't belong to any
input section.

This patch is based on https://reviews.llvm.org/D36520

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.Aug 9 2017, 1:16 PM
Herald added a subscriber: emaste. · View Herald TranscriptAug 9 2017, 1:16 PM
Harbormaster completed remote builds in B9175: Diff 110464.Aug 9 2017, 1:17 PM
ruiu updated this revision to Diff 110474.Aug 9 2017, 1:59 PM
  • Address review comment.
grimar accepted this revision.EditedAug 10 2017, 12:44 AM

LGTM, thanks !

lld/ELF/Symbols.h
165 ↗(On Diff #110474)

Should it be unsigned isLive: 1 ? (for consistency with flags in SymbolBody)

This revision is now accepted and ready to land.Aug 10 2017, 12:44 AM
grimar mentioned this in D36520: [ELF] - Implemented GC for common symbols..Aug 10 2017, 12:47 AM
Closed by commit rL310617: Garbage-collect common symbols. (authored by ruiu). · Explain WhyAug 10 2017, 8:55 AM
This revision was automatically updated to reflect the committed changes.
ruiu added inline comments.Aug 10 2017, 8:56 AM
lld/ELF/Symbols.h
165 ↗(On Diff #110474)

No, you don't want to use bitfields unless it is necessary. bool is the standard type to represent a true/false variable.

Revision Contents
Changeset List

PathSize
lld/
trunk/
ELF/
22 lines
10 lines
2 lines
4 lines
4 lines
test/
ELF/
41 lines
15 lines

Diff 110590

View Options

lld/trunk/ELF/MarkLive.cpp

Loading...
View Options

lld/trunk/ELF/Symbols.h

Loading...
View Options

lld/trunk/ELF/Symbols.cpp

Loading...
View Options

lld/trunk/ELF/SyntheticSections.cpp

Loading...
View Options

lld/trunk/ELF/Writer.cpp

Loading...
View Options

lld/trunk/test/ELF/common-gc.s

Loading...
View Options

lld/trunk/test/ELF/common-gc2.s

Loading...