Page MenuHomePhabricator

[ELF] - Implemented GC for common symbols.
AbandonedPublic

Authored by grimar on Aug 9 2017, 7:11 AM.

Details

Reviewers
ruiu
rafael
Summary

This is PR33887, previously unused common symbols
were not collected.

Diff Detail

Event Timeline

grimar created this revision.Aug 9 2017, 7:11 AM
ruiu edited edge metadata.Aug 9 2017, 11:59 AM

I think this patch needs rewriting because it uses a callback function where you don't actually have to and uses Offset as a different meaning than it should be. I'll send you an updated one.

grimar abandoned this revision.Aug 10 2017, 12:47 AM
In D36520#837109, @ruiu wrote:

I think this patch needs rewriting because it uses a callback function where you don't actually have to and uses Offset as a different meaning than it should be. I'll send you an updated one.

Live bit is the first thing I was thinking of honestly. Then decided to reuse Offset, supposed that new field will became a problem during review :)
Abandoning in favor of D36546.