Page MenuHomePhabricator
Differential D36433

[KnownBits][ValueTracking] Move the math for calculating known bits for add/sub into a static method in KnownBits object
ClosedPublic
Actions

Authored by craig.topper on Aug 7 2017, 3:52 PM.

Details

Reviewers
spatel
majnemer
davide
Commits
rGb498a23f0e75: [KnownBits][ValueTracking] Move the math for calculating known bits for add/sub…
rL310378: [KnownBits][ValueTracking] Move the math for calculating known bits for add/sub…
Summary

I want to reuse this code in SimplifyDemandedBits handling of Add/Sub. This will make that easier.

Wonder if we should use it in SelectionDAG's computeKnownBits too.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Aug 7 2017, 3:52 PM
Herald added a subscriber: mgorny. · View Herald TranscriptAug 7 2017, 3:52 PM
mcrosier added a subscriber: mcrosier.Aug 8 2017, 7:20 AM
davide edited edge metadata.Aug 8 2017, 8:02 AM

If we can share this with SelDAG as well it would be even more awesome. I have no objections to this refactoring but please wait to hear from David

majnemer accepted this revision.Aug 8 2017, 8:58 AM

LGTM

This revision is now accepted and ready to land.Aug 8 2017, 8:58 AM
Closed by commit rL310378: [KnownBits][ValueTracking] Move the math for calculating known bits for add/sub… (authored by ctopper). · Explain WhyAug 8 2017, 9:30 AM
This revision was automatically updated to reflect the committed changes.
nikic mentioned this in D60522: [KnownBits] Add computeForAddCarry().Apr 11 2019, 9:11 AM

Revision Contents
Changeset List

PathSize
include/
llvm/
Support/
4 lines
lib/
Analysis/
42 lines
Support/
1 line
65 lines
llvm/
trunk/
include/
llvm/
Support/
4 lines
lib/
Analysis/
42 lines
Support/
1 line
65 lines

Diff 110218

View Options

include/llvm/Support/KnownBits.h

Loading...
View Options

lib/Analysis/ValueTracking.cpp

Loading...
View Options

lib/Support/CMakeLists.txt

Loading...
View Options

lib/Support/KnownBits.cpp

Loading...
View Options

llvm/trunk/include/llvm/Support/KnownBits.h

Loading...
View Options

llvm/trunk/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/trunk/lib/Support/CMakeLists.txt

Loading...
View Options

llvm/trunk/lib/Support/KnownBits.cpp

Loading...