This is an archive of the discontinued LLVM Phabricator instance.

Differential D36417

AMDGPU: Remove redundant opt level check
ClosedPublic

Authored by arsenm on Aug 7 2017, 10:45 AM.

Download Raw Diff

Details

Reviewers

rampitec

Summary

addOptimizedRegAlloc isn't used for -O0 already.

Diff Detail

Event Timeline

arsenm created this revision.Aug 7 2017, 10:45 AM

Herald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald TranscriptAug 7 2017, 10:45 AM

Good to know. LGTM.

This revision is now accepted and ready to land.Aug 7 2017, 11:05 AM

r310275

Revision Contents

Path

Size

lib/

Target/

AMDGPU/

AMDGPUTargetMachine.cpp

3 lines

Diff 110028

lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

Show First 20 Lines • Show All 793 Lines • ▼ Show 20 Lines	void GCNPassConfig::addFastRegAlloc(FunctionPass *RegAllocPass) {
// This must be run after SILowerControlFlow, since it needs to use the		// This must be run after SILowerControlFlow, since it needs to use the
// machine-level CFG, but before register allocation.		// machine-level CFG, but before register allocation.
insertPass(&SILowerControlFlowID, &SIFixWWMLivenessID, false);		insertPass(&SILowerControlFlowID, &SIFixWWMLivenessID, false);

TargetPassConfig::addFastRegAlloc(RegAllocPass);		TargetPassConfig::addFastRegAlloc(RegAllocPass);
}		}

void GCNPassConfig::addOptimizedRegAlloc(FunctionPass *RegAllocPass) {		void GCNPassConfig::addOptimizedRegAlloc(FunctionPass *RegAllocPass) {
if (getOptLevel() > CodeGenOpt::None)
insertPass(&MachineSchedulerID, &SIOptimizeExecMaskingPreRAID);		insertPass(&MachineSchedulerID, &SIOptimizeExecMaskingPreRAID);

// This must be run immediately after phi elimination and before		// This must be run immediately after phi elimination and before
// TwoAddressInstructions, otherwise the processing of the tied operand of		// TwoAddressInstructions, otherwise the processing of the tied operand of
// SI_ELSE will introduce a copy of the tied operand source after the else.		// SI_ELSE will introduce a copy of the tied operand source after the else.
insertPass(&PHIEliminationID, &SILowerControlFlowID, false);		insertPass(&PHIEliminationID, &SILowerControlFlowID, false);

// This must be run after SILowerControlFlow, since it needs to use the		// This must be run after SILowerControlFlow, since it needs to use the
// machine-level CFG, but before register allocation.		// machine-level CFG, but before register allocation.
Show All 40 Lines