This is an archive of the discontinued LLVM Phabricator instance.

[Targets] Move RTEMS to OSTargets.h
ClosedPublic

Authored by waltl on Jul 31 2017, 1:01 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

waltl created this revision.Jul 31 2017, 1:01 PM
waltl added a reviewer: erichkeane.
waltl retitled this revision from Move RTEMS to OSTargets.h to [Targets] Move RTEMS to OSTargets.h.Jul 31 2017, 1:09 PM
erichkeane accepted this revision.Jul 31 2017, 1:24 PM

LGTM. Just wondering, is there a different target that is going to use this? Also was wondering if you knew about the mcount value?

lib/Basic/Targets/OSTargets.h
516 ↗(On Diff #108981)

Do we know why the MCountNames are commented out/not set?

This revision is now accepted and ready to land.Jul 31 2017, 1:24 PM
waltl added a comment.Jul 31 2017, 1:43 PM

LGTM. Just wondering, is there a different target that is going to use this? Also was wondering if you knew about the mcount value?

Thanks for the quick review. We have a Sparc-based target that uses RTEMS but currently does not require specialization of that class.

lib/Basic/Targets/OSTargets.h
516 ↗(On Diff #108981)

I don't know. FWIW, I traced that back to the initial commit of RTEMSTargetInfo in dca52265 by Douglas Gregor.

This revision was automatically updated to reflect the committed changes.