This is an archive of the discontinued LLVM Phabricator instance.

[lit] Avoid copying llvm/utils/lit/tests/Inputs with lit site configs
ClosedPublic

Authored by rnk on Jul 28 2017, 3:26 PM.

Details

Summary

This is an alternative solution to running the lit test suite on bots
without polluting the source directory. Each input test suite gets an
auto-generated site config in the build directory that points back to
the test input source directory.

This adds some cmake comlexity, but now we don't need to remove and
re-copy the test input directory before every test.

Event Timeline

rnk created this revision.Jul 28 2017, 3:26 PM
modocache accepted this revision.Jul 29 2017, 10:48 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 29 2017, 10:48 AM

Well, I can confirm that it doesn't break running in place ;-).

This revision was automatically updated to reflect the committed changes.
modocache added a comment.EditedAug 2 2017, 9:05 AM

@rnk After this patch, the check-lit target leaves untracked files in the source tree:

utils/lit/tests/Inputs/max-failures/Output/
utils/lit/tests/Inputs/shtest-format/external_shell/Output/
utils/lit/tests/Inputs/shtest-output-printing/Output/
utils/lit/tests/Inputs/shtest-shell/Output/

How would you feel if I reverted this for now? I think this change is the right way forward but it might need some tweaking to prevent the above artifacts from being generated.

rnk added a comment.Aug 2 2017, 10:13 AM

@rnk After this patch, the check-lit target leaves untracked files in the source tree:

utils/lit/tests/Inputs/max-failures/Output/
utils/lit/tests/Inputs/shtest-format/external_shell/Output/
utils/lit/tests/Inputs/shtest-output-printing/Output/
utils/lit/tests/Inputs/shtest-shell/Output/

How would you feel if I reverted this for now? I think this change is the right way forward but it might need some tweaking to prevent the above artifacts from being generated.

Yeah, let's do that, it's not working as intended, and it doesn't look easy to fix.

llvm/CMakeLists.txt