Page MenuHomePhabricator

Update phi nodes in LowerTypeTests control flow simplification
ClosedPublic

Authored by vlad.tsyrklevich on Jul 28 2017, 12:18 PM.

Details

Summary

D33925 added a control flow simplification for -O2 --lto-O0 builds that manually splits blocks and reassigns conditional branches but does not correctly update phi nodes. If the else case being branched to had incoming phi nodes the control-flow simplification would leave phi nodes in that BB with an unhandled predecessor.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc accepted this revision.Jul 28 2017, 1:05 PM

LGTM

lib/Transforms/IPO/LowerTypeTests.cpp
638 ↗(On Diff #108691)

Nit: rename to Phi.

This revision is now accepted and ready to land.Jul 28 2017, 1:05 PM
vlad.tsyrklevich marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.